rtc - 如何使用 "submit for review"功能审查在 RTC 中提交给我的代码？

Question

我正在使用 RTC，
我的 friend 提交了他们的更改集以供审核，我是审核者。我在任何地方都找不到他们的变更集。

Answer 1

This thread总结过程:

项目配置:

• Precondition set: "Require Work Item Approval" for "Deliver (client)" operation for "Everyone" role.
• In the "Required approvals", for the "Review" type, at least one from "Everyone" role (or "Team Member" role) is set.

"User may overrule" may also be checked if not all code delivery may require a review process.

设想:

三个开发者 - D1 , D2 & D3 - 全部使用 RTC Eclipse 客户端。

• D1 does the code change for files f1 & f2 in her local workspace and saves them. f1 and f2 appears as unresolved in the pending changes view.
• D1 checks-in f1 & f2 into a new change set "CS".
  Right clicks on "CS" and select "Submit for Review" menu option and associate to a WI (existing or a new one) and select approvers:
  • D2 as the approver for f1 review (subject field is used to tell what to review) and
  • D3 as approver for f2 review.
• The approval/Review process will be in the pending state.
• D2 & D3 gets intimation of the review task assigned to them through a query - "Pending approvals for me".
• D2 opens the WI and in the Links section, double clicks on the f1 in the change set and see the diff in the Change Explorer.
  Does the review.
  Optionally, adds comment for D1 in the discussion field of the WI.
  Changes the Review approval state from pending to approved.
  D3 follows the same process as D2 but rejects because the f3 code change is not acceptable. Changes the Review approval state from pending to rejected.
• D1 gets the review comment via email/feed - because D1 is the owner and the subscriber of the WI.
• D1 fixes the code in f2 based on D3's review and checks in to the same changeset.
• D1 adds D3 again for the new review approval in the same WI.
• D3 gets intimation of the review task assigned to him through a query - "Pending approvals for me".
• D3 opens the WI and in the Links section, double clicks on the f2 in the change set and see the diff in the Change Explorer.
  Does the review.
  Optionally, adds comment for D1 in the discussion field of the WI.
  Changes the Review approval state from pending to approved.
• D1 gets the review comment via email/feed - because D1 is the owner and the subscriber of the WI.
• D1 delivers the changeset (or invokes "Complete" action on the changeset) because all the approvals in the WI are in approved state.
• The complete history of the code review process (rejected ones, approved ones) are in the "Approvals" tab.