javascript - 我的 JS 代码适合 '99 Bottles of Beer on the Wall' 歌曲吗？

Question

关闭。这个问题是 opinion-based 。目前不接受答案。

---

想要改进这个问题吗？更新问题，以便 editing this post 可以用事实和引文来回答它。 .

已关闭 2 年前。

Improve this question

JS新手在这里寻求一些建议。我一直在阅读《Head First JavaScript 编程》一书，它向我展示了如何将“99 Bottles of Beer on the Wall”歌曲记录到控制台。原始代码如下:

var word = "bottles";
var count = 99;
while (count > 0) {
    console.log(count + " " + word + " of beer on the wall");
    console.log(count + " " + word + " of beer,");
    console.log("Take one down, pass it around,");
    count = count - 1;
    if (count > 0) {
        console.log(count + " " + word + " of beer on the wall.");
    } else {
        console.log("No more " + word + " of beer on the wall.");
    }
}

在没有给出答案的情况下，它表明代码没问题，但不是 100% 正确，并询问您是否可以找到缺陷并​​修复它。查看控制台后，我发现 while 循环没有考虑到歌曲中的一瓶啤酒时，“bottles”一词需要更改为“bottle”。我在循环中添加了一些 if 语句，以便在需要时将 var 单词更改为“bottle”。该代码现在似乎可以正常工作:

var word = "bottles";
var count = 99;
while (count > 0) {
  if (count == 1){
    var word = "bottle"
  }
    console.log(count + " " + word + " of beer on the wall");
    console.log(count + " " + word + " of beer,");
    console.log("Take one down, pass it around,");
    count = count - 1;
    if (count > 0) {
      if (count == 1){
        var word = "bottle"
      }
        console.log(count + " " + word + " of beer on the wall.");
    } else {
      if (count < 1){
        var word = "bottles"
      }
        console.log("No more " + word + " of beer on the wall.");
    }
}

我的问题是 - 有没有比我的尝试更好、或更简洁的方法来做到这一点？我感觉我的尝试有点困惑。我知道您可以为此使用 For 循环，但该示例使用了 While 循环，因此如果可能的话，我想坚持使用该循环。

非常感谢!

Answer 1

您可以通过用简洁的三元表达式替换那些庞大的 if else 语句来稍微整理一下逻辑:

while (count > 0) {
    var bottle = count == 1 ? "bottle" : "bottles";
    console.log(count + " " + word + " of beer on the wall");
    console.log(count + " " + word + " of beer,");
    console.log("Take one down, pass it around,");
    --count;
    var bottle = count == 1 ? "bottle" : "bottles";
    console.log(count + " " + word + " of beer on the wall.");
}

这从语法上假设短语0 Bottles of beer on the wall是正确的，并且是我们想要使用的。这对我来说听起来不错，但我想从技术上讲 0 或 1 瓶都应该是单数。