Javascript选择div并更改里面的href

Question

我正在尝试使用 JavaScript 修改页面中的链接。我可以选择 div 和 a 元素，但无法更改 href。

Shopify 使用 for 循环来生成这些对象，并且需要每个对象都有不同的链接。

这是 HTML:

<div id="tri-banner-1" class="banner-element banner-1 col-sm-4">
                <a href="collections/all"><div class="home-banner">                  
                  <img src='//cdn.shopify.com/s/files/1/1093/4220/t/2/assets/group_top_banner01.png?17711418137279289271' alt="">
                  <div class="banner-caption">
                    <div class="display-table">
                      <div class="display-tablecell">

                      </div>
                    </div>                        
                  </div>                 
                </div></a>                                     
              </div>  



              <div id="tri-banner-2" class="banner-element banner-2 col-sm-4">
                <a href="collections/all"><div class="home-banner">                  
                  <img src='//cdn.shopify.com/s/files/1/1093/4220/t/2/assets/group_top_banner02.png?17711418137279289271' alt="">
                  <div class="banner-caption">
                    <div class="display-table">
                      <div class="display-tablecell">

                      </div>
                    </div>                        
                  </div>                 
                </div></a>                                     
              </div>  



              <div id="tri-banner-3" class="banner-element banner-3 col-sm-4">
                <a href="collections/all"><div class="home-banner">                  
                  <img src='//cdn.shopify.com/s/files/1/1093/4220/t/2/assets/group_top_banner03.png?17711418137279289271' alt="">
                  <div class="banner-caption">
                    <div class="display-table">
                      <div class="display-tablecell">

                      </div>
                    </div>                        
                  </div>                 
                </div></a>                                     
              </div> 

这是我的 JavaScript。

<script type="text/javascript">

  $(window).bind("load", function() {
      window.alert("Test");
      var banner1 = document.getElementById("tri-banner-1");
      var banner1Links = banner1.getElementsByTagName("a");
      banner1Links.href="facebook.com";
  });
</script>

Answer 1

banner1.getElementsByTagName("a"); 返回 HTMLCollection 。您应该使用索引选择元素；例如；

// set `href` of first `a` element in `bannerLinks`
banner1Links[0].href = "facebook.com";

或者迭代集合

for (var i = 0; i < bannerLinks.length; i++) {
  bannerLinks[i] = /* set `href` here */;
}