java - Swing - 当内存游戏结束时计时器不会停止

Question

我正在尝试创建一个有 12 个切换按钮的内存游戏。如果您单击一个按钮，图标就会改变。如果两个图标匹配，则两个图标都会翻转。我在游戏顶部显示了一个已用计时器。我想让计时器在游戏结束时停止；然而，计时器仍然继续运转。这就是我所拥有的:

import java.awt.*;
import java.awt.event.*;
import java.util.ArrayList;
import java.util.Arrays;
import javax.swing.*;
import java.util.Collections;
import java.util.Calendar;
import java.time.*;

public class MemoryGame extends JToggleButton implements ActionListener {

private Timer cdTimer;
private Timer swTimer;

private int count = 0;
private long start;
private long begin = Calendar.getInstance().getTimeInMillis();

private JToggleButton[] buttons;
private JToggleButton last;
private JLabel time;
//private String[] commandID = {"0", "1", "2", "3", "4", "5", "6", "7", "8", "9", "10", "11"};
ArrayList<ImageIcon> iconList = new ArrayList();
ArrayList<JToggleButton> retireButton = new ArrayList();
ImageIcon icon = new ImageIcon("MemoryGame.png");


public MemoryGame() {
    JFrame jfrm = new JFrame("Memory Game");

    jfrm.setSize(1000, 1000);

    jfrm.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);

    jfrm.setIconImage(icon.getImage());

    time = new JLabel("Elapsed time is 00:00:00");

    GridLayout layout = new GridLayout(3,4);

    JPanel gamePanel = new JPanel();
    gamePanel.setLayout(layout);

    createIcons();

    buttons = new JToggleButton[12];

    for(int i = 0; i < buttons.length; i++) {
        JToggleButton btn = new JToggleButton(icon);

        buttons[i] = btn;

        //buttons[i].setActionCommand(commandID[i]);

        buttons[i].addActionListener(this);

        gamePanel.add(buttons[i]);   
    }

    //Collections.shuffle(Arrays.asList(buttons));
    //Collections.shuffle(iconList);

    jfrm.add(gamePanel, BorderLayout.CENTER);
    time.setHorizontalAlignment(JLabel.CENTER);
    time.setVerticalAlignment(JLabel.CENTER);
    jfrm.add(time, BorderLayout.NORTH);

    jfrm.setLocationRelativeTo(null);

    jfrm.setVisible(true);
}

public void actionPerformed(ActionEvent e){

    timerStart();

    JToggleButton btn = (JToggleButton)e.getSource();

    setIcon(btn);
    if(last == null){
        last = btn;
        return;
    }

    matching(btn, last);

    last = null;

}

public void updateTime(){
    long temp = Calendar.getInstance().getTimeInMillis();
    time.setText("Elapsed time is " + formatTime((long) (temp - begin)) + "-"+retireButton.size());
}

public static String formatTime(long ms){
    long millis = ms % 1000;
    long x = ms / 1000;
    long seconds = x % 60;
    x /= 60;
    long minutes = x % 60;
    x /= 60;
    long hours = x % 24;

    return String.format("%02d:%02d:%02d", hours, minutes, seconds);
}

private void timerStart(){
    ActionListener timerAL = new ActionListener(){
        public void actionPerformed(ActionEvent e){
            updateTime();
        }
    };
    swTimer = new Timer(1000, timerAL);
    swTimer.start();
}

private void timerStop(){
    if(retireButton.size() == 12){
        long stop = Calendar.getInstance().getTimeInMillis();
        time.setText("Elapsed time is " + formatTime((long)(stop-begin)));
        swTimer.stop();
    }
}
private void setIcon(JToggleButton btn) {
    if(btn == buttons[0] || btn == buttons[1])
        btn.setIcon(iconList.get(0)); 

    else if(btn == buttons[2] || btn == buttons[3])
        btn.setIcon(iconList.get(1));

    else if(btn == buttons[4] || btn == buttons[5])
        btn.setIcon(iconList.get(2));

    else if(btn == buttons[6] || btn == buttons[7])
        btn.setIcon(iconList.get(3));

    else if(btn == buttons[8] || btn == buttons[9])
        btn.setIcon(iconList.get(4));

    else if(btn == buttons[10] || btn == buttons[11])
        btn.setIcon(iconList.get(5));
}

private void matching(JToggleButton btn, JToggleButton btn2){
    if(btn.isSelected()){
        if(btn2.isSelected()){
            buttonDisable(btn, btn2);
            if(!btn.getIcon().toString().equals(btn2.getIcon().toString())){
                startTime(1, btn, btn2);
            }
            else {
                retirePair(btn, btn2);
                timerStop();
                buttonEnable(btn, btn2);
            }
        }
    }   
}

private void startTime(int countPassed, JToggleButton btn, JToggleButton btn2){
    ActionListener action = new ActionListener(){
        public void actionPerformed(ActionEvent e){
            if(count == 0){
                cdTimer.stop();
                unflipPair(btn, btn2);
                buttonEnable(btn, btn2);
            }
            else
                count--;
            }

    };
    cdTimer = new Timer(500, action);
    cdTimer.start();
    count = countPassed;
}

private void buttonEnable(JToggleButton btn, JToggleButton btn2){
    if(retireButton.isEmpty()){
        for(int i = 0; i < buttons.length; i++){
            if(buttons[i] != btn && buttons[i] != btn2)
                buttons[i].setEnabled(true);
        }
    }    
    else{
        for(int i = 0; i < buttons.length; i++){
            for(int j = 0; j < retireButton.size(); j++){        
                if(buttons[i] != btn && buttons[i] != btn2 && buttons[i] != retireButton.get(j))
                    buttons[i].setEnabled(true);
            }   
        }
    }
}

private void buttonDisable(JToggleButton btn, JToggleButton btn2){
    for(int i = 0; i < buttons.length; i++){
        if(buttons[i] != btn && buttons[i] != btn2)
            buttons[i].setEnabled(false);
    }
}
private void unflipPair(JToggleButton btn, JToggleButton btn2){
    btn.setIcon(icon);
    btn2.setIcon(icon);
    btn.setEnabled(true);
    btn2.setEnabled(true);
    btn.setSelected(false);
    btn2.setSelected(false);
}

private void retirePair(JToggleButton btn, JToggleButton btn2){
    btn.setEnabled(false);
    btn2.setEnabled(false);
    btn.setSelected(true);
    btn2.setSelected(true);
    retireButton.add(btn);
    retireButton.add(btn2);
}

private void createIcons(){
    ImageIcon icon1 = new ImageIcon("1.png");
    ImageIcon icon2 = new ImageIcon("2.png");
    ImageIcon icon3 = new ImageIcon("3.png");
    ImageIcon icon4 = new ImageIcon("4.png");
    ImageIcon icon5 = new ImageIcon("5.png");
    ImageIcon icon6 = new ImageIcon("6.png");

    iconList.add(icon1);
    iconList.add(icon2);
    iconList.add(icon3);
    iconList.add(icon4);
    iconList.add(icon5);
    iconList.add(icon6);
}

所以我创建了一个退休按钮的数组列表。我为计时器设置的停止条件是，如果退出按钮数组列表大小达到12(即游戏中按钮的总数)，则计时器停止；然而，它只是继续下去。我不知道我做错了什么。请帮忙谢谢。

Answer 1

这是我看到的一个问题 - 您正在创建很多 Timer 实例，您将它们放入 swTimer 变量中，但只尝试停止最后一个实例，而所有其他实例仍在继续运行。一种可能的解决方案 - 在创建新的 Timer 实例之前，查看当前是否正在运行，如果是，则停止它。

例如，

private void timerStart() {
    ActionListener timerAL = new ActionListener() {
        public void actionPerformed(ActionEvent e) {
            updateTime();
        }
    };
    // check if swTimer is not null and is currently running
    if (swTimer != null && swTimer.isRunning()) {
        swTimer.stop(); // !! if so STOP it!
    }
    swTimer = new Timer(1000, timerAL);
    swTimer.start();
}

话虽如此，您真的需要创建所有这些新的 Timer 实例吗？难道单个实例不能工作吗？一个实例在按下第一个按钮时启动，仅在游戏结束时停止？

附带问题(与当前问题无关):

• 这不属于:MemoryGame 扩展 JToggleButton。该游戏绝对不是 JToggleButton，因此您不应该让该类扩展此类。
• 你的游戏逻辑很复杂，很难测试，而且可能有点偏差。最好将逻辑与 GUI 分开，这样您就可以使用一系列非 GUI 测试来独立测试它，看看它是否正常工作。