iphone - 丑陋的 heightForRowAtIndexPath 和 cellForRowAtIndexPath

Question

我有一个 UItableview ，我正在填充数据，使用 heightForRowAtIndexPath和 cellForRowAtIndexPath .显然苹果让我在我的代码中做两次事情。

首先，我必须在 heightForRowAtIndexPath 中计算我的 View 的大小(为此我必须制作它们)。然后我必须再次制作它们，将它们添加到实际 View 中。

我有一个非常复杂的 View ，所以当你必须写两次时​​，它看起来很丑。

难道没有更好的方法来做到这一点吗？

更新

这就是我的代码的外观。它不完全一样，但非常接近。为什么苹果让我写两次？

- (CGFloat)tableView:(UITableView *)tableView heightForRowAtIndexPath:(NSIndexPath *)indexPath{
    NSLog(@"heightForRowAtIndexPath");

    //Initiating strings
    NSString *headlineString;
    NSString *subHeadlineString;
    NSString *bylineString;
    if (global.magazine.issues.count==0) {
        return 45;
    }else if(indexPath.section == global.magazine.issues.count+1) {
        //Finding the right issue and article for this row
        Issue *issue = [global.magazine.issues objectAtIndex:global.magazine.issues.count-1];

        //Creating the headline
        headlineString = [NSString stringWithFormat:@"<span class='bold_style'>FOREWORD</span>"];

        //Creating the subHeadline
        subHeadlineString = [NSString stringWithFormat:@"%@", [issue.magazine_foreword substringToIndex:100]];

        //Creating byline
        bylineString = [[NSString stringWithFormat:@"<span class='ital_style'>By %@</span>", issue.magazine_byline] capitalizedString];
    }else{
        //Finding the right issue and article for this row
        Issue *issue = [global.magazine.issues objectAtIndex:indexPath.section-1];
        Article *article = [issue.articles objectAtIndex:indexPath.row];

        //Creating the headline
        headlineString = [NSString stringWithFormat:@"<span class='bold_style'>%@</span>", [article.title uppercaseString]];

        //Creating the subHeadline
        subHeadlineString = [NSString stringWithFormat:@"%@", [article.main_text substringToIndex:100]];

        //Creating byline
        bylineString = [NSString stringWithFormat:@"<span class='ital_style'>By %@</span>", article.byline];
    }

    //Creating the labels
    NMCustomLabel *headline = [global.label headLineLabelWithString:headlineString fromTop:30 withWidth:global.screenWidth-60];
    NMCustomLabel *subHeadline = [global.label subHeadlineLabelWithString:subHeadlineString fromTop:30+headline.height+10 withWidth:global.screenWidth-60];
    NMCustomLabel *byline = [global.label articleBylineLabelWithString:bylineString fromTop:30+headline.height+10+subHeadline.height+10 withWidth:global.screenWidth-60];

    //Setting the height of the row
    return 30+headline.height+10+subHeadline.height+10+byline.height+30;
}

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath{
    NSLog(@"cellForRowAtIndexPath");
    //Preparing the cell
    static NSString *CellIdentifier = @"Cell";
    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier forIndexPath:indexPath];
    if (cell == nil) {
        cell = [[UITableViewCell alloc]
                initWithStyle:UITableViewCellStyleDefault
                reuseIdentifier:CellIdentifier];
    }

    //Removing former text views
    for (UIView *subview in [cell subviews]) {
        if (subview.tag == 21 || subview.tag == 22 || subview.tag == 23) [subview removeFromSuperview];
    }

    //Removing and setting tableview border
    [[cell viewWithTag:30] removeFromSuperview];
    UIView *rightBorder = [[UIView alloc] initWithFrame:CGRectMake(cell.width-1, 0, 1, cell.height)];
    rightBorder.backgroundColor = global.lightGrey;
    rightBorder.tag = 30;
    [cell addSubview:rightBorder];

    //Setting the seletion background color on the cells
    UIView *bgColorView = [[UIView alloc] init];
    bgColorView.backgroundColor = global.extraLightGrey;
    cell.selectedBackgroundView = bgColorView;
    if (global.magazine.issues.count==0) {
        return cell;
    }else if (indexPath.section-1 == global.magazine.issues.count) {
        //Finding the right issue and article for this row
        Issue *issue = [global.magazine.issues objectAtIndex:global.magazine.issues.count-1];

        //Creating the headline
        NSString *headlineString = [NSString stringWithFormat:@"<span class='bold_style'>FOREWORD</span>"];
        NMCustomLabel *headline = [global.label headLineLabelWithString:headlineString fromTop:30 withWidth:global.screenWidth-60];
        headline.tag = 21;
        [cell addSubview:headline];

        //Creating the subHeadline
        NSString *subHeadlineString = [[NSString stringWithFormat:@"%@", issue.magazine_foreword] substringToIndex:100];
        NMCustomLabel *subHeadline = [global.label subHeadlineLabelWithString:subHeadlineString fromTop:30+headline.height+10 withWidth:global.screenWidth-60];
        subHeadline.tag = 22;
        [cell addSubview:subHeadline];

        //Creating byline
        NSString *bylineString = [[NSString stringWithFormat:@"<span class='ital_style'>By %@</span>", issue.magazine_byline] capitalizedString];
        NMCustomLabel *byline = [global.label articleBylineLabelWithString:bylineString fromTop:30+headline.height+10+subHeadline.height+10 withWidth:global.screenWidth-60];
        byline.tag = 23;
        [cell addSubview:byline];
    }else{
        //Finding the right issue and article for this row
        Issue *issue = [global.magazine.issues objectAtIndex:indexPath.section-1];
        Article *article = [issue.articles objectAtIndex:indexPath.row];

        //Creating the headline
        NSString *headlineString = [NSString stringWithFormat:@"<span class='bold_style'>%@</span>", [article.title uppercaseString]];
        NMCustomLabel *headline = [global.label headLineLabelWithString:headlineString fromTop:30 withWidth:global.screenWidth-60];
        headline.tag = 21;
        [cell addSubview:headline];

        //Creating the subHeadline
        NSString *subHeadlineString = [NSString stringWithFormat:@"%@", [article.main_text substringToIndex:100]];
        NMCustomLabel *subHeadline = [global.label subHeadlineLabelWithString:subHeadlineString fromTop:30+headline.height+10 withWidth:global.screenWidth-60];
        subHeadline.tag = 22;
        [cell addSubview:subHeadline];

        //Creating byline
        NSString *bylineString = [[NSString stringWithFormat:@"<span class='ital_style'>By %@</span>", article.byline] capitalizedString];
        NMCustomLabel *byline = [global.label articleBylineLabelWithString:bylineString fromTop:30+headline.height+10+subHeadline.height+10 withWidth:global.screenWidth-60];
        byline.tag = 23;
        [cell addSubview:byline];
    }

    return cell;
}

Answer 1

最简单的解决方案是遵循 DRY 原则，或者添加高度作为您用作数据源的对象的属性，或者向 View Controller 添加方法，例如:

-(CGFloat)calculateHeightForHeadline:(NSString*)headline andSubHeadline:(NSString*)subHeadline andByLine:(NSString*)byLine

那么至少你在一个地方只有计算代码。

或者，您可以调用 [tableView heightForRowAtIndexPath:indexPath]从你的 cellForRowAtIndexPath 方法