java - 卡组驱动java

Question

我已经解决了这个问题，现在它可以正常运行了，我的问题是，我的构造函数出了什么问题？正如有人指出有一个问题，但我找不到它，我也想从我的牌组中提取并删除一张卡，有关于如何做这样的事情的指示吗？

我的套牌类别:

 import java.util.*;


public class Deck {

    private static Card[] cards;
    private static int counter;

    int i=52;
    int x=0;

    public Deck(Card[] card){
this.cards=card;
    }



    public int createDeck(){

        cards = new Card[52];
        for (int a=0; a<=3; a++)
        {
            for (int b=0; b<=12; b++)
            {
                cards[x] = new Card(a,b);
                x++;
                counter++;
            }
        }

    }


    public Card[] resetDeck(){
        createDeck();
        return cards;
    }

    public static void getRandomCard(){
        int chosen = (int) (52*Math.random())+1;
        System.out.println(cards[chosen]);
    }

    public static int getCounter(){
        return counter;
    }

    public static void print(){

         for(int x=0;x<52;x++){
            System.out.println(Deck.cards[x]);
        }
    }


}

我的 DecktestDriver

public class DeckTestDriver {
    public static void main(String[] args){

        Deck test = new Deck(new Card[52]);
        test.createDeck();

        int input =test.getCounter();
        System.out.println("Number of cards in Deck = "+input);

        System.out.print("looking at one card in the deck-----");
        test.getRandomCard();
        System.out.println(".........................");

        System.out.println("Printing full list of cards in deck");
        System.out.println(".........................");

    test.print();
    System.out.println();
    System.out.println(".........................");
    System.out.println();

    System.out.println("Creating New Deck");
    System.out.println(".........................");
    System.out.println();

    Deck test1 = new Deck(new Card[52]);
    test1.createDeck();
    System.out.println();

    System.out.println("Printing new full list of cards in deck");
    System.out.println(".........................");

test1.print();
System.out.println(".........................");
System.out.println();

int input1 =test1.getCounter();
System.out.println("Number of cards in Deck = "+input1);

System.out.print("looking at one card in the deck-----");
test1.getRandomCard();
System.out.println(".........................");

    }
}

我的卡类别:

public class Card {

    private int CardFaceValue;
    private int CardFaceSuit;
    private int cardFlippedNum;
    private int cardFlippedSuit;
    final static int MIN_VALUE_NUM=1;
    final static String MIN_VALUE_SUIT="Diamond";
    final static int MAX_VALUE_NUM=13;
    final static String MAX_VALUE_SUIT="Spade";



    public Card(int cardFlippedNum,int cardFlippedSuit){
        cardFlippedNumber();
        cardFlippedSuitType();

    }



    public int cardFlippedNumber(){
        int cFn = (int) (Math.random()*13)+1;
        cardFlippedNum = cFn;
        return CardFaceValue;

    }
    public int cardFlippedSuitType(){
        int cFs = (int)(Math.random()*4)+1;

        cardFlippedSuit = cFs;

        return CardFaceSuit;

    }



    public int getNum(){

        return cardFlippedNum;
    }

    public int getSuit(){
        return cardFlippedSuit;

    }

    public String toString() {      
        return (getCardName() + " of " + getSuitName());
    }

    public String getCardName() {
        switch (cardFlippedNum) {           //Change return cases to numbers if you want a number shown e.g: 1 of Hearts
        case 1:
            return ("Ace"); 
        case 2:
            return ("TWO");
        case 3:
            return ("THREE");
        case 4:
            return ("FOURTH");
        case 5:
            return ("FIVE");
        case 6:
            return ("SIX");
        case 7:
            return ("SEVEN");
        case 8:
            return ("EIGHT");
        case 9:
            return ("NINE");
        case 10:
            return ("TEN");
        case 11:
            return ("Jack");
        case 12:
            return ("Queen");
        case 13:
            return ("King");
        default:
            return ("" + cardFlippedNum);
        }
    }

    public String getSuitName() {
        switch (cardFlippedSuit) {
        case 1:
            return ("Diamonds");
        case 2:
            return ("Clubs");
        case 3:
            return ("Hearts");
        case 4:
            return ("Spades");
        default:
            return ("Invalid");
        }
    }



}

我的输出:

     Number of cards in Deck = 52
looking at one card in the deck-----Jack of Clubs
.........................
Printing full list of cards in deck
.........................
TWO of Spades
SIX of Clubs
NINE of Hearts
TWO of Diamonds
FOURTH of Clubs
FOURTH of Spades
TEN of Clubs
Jack of Spades
EIGHT of Diamonds
Queen of Diamonds
Queen of Diamonds
TEN of Spades
EIGHT of Hearts
Ace of Hearts
SIX of Diamonds
King of Clubs
THREE of Diamonds
TWO of Hearts
SIX of Spades
SIX of Hearts
THREE of Spades
EIGHT of Hearts
FIVE of Clubs
EIGHT of Diamonds
Jack of Clubs
Ace of Diamonds
NINE of Diamonds
SEVEN of Hearts
TEN of Diamonds
SEVEN of Diamonds
SEVEN of Diamonds
EIGHT of Hearts
FIVE of Hearts
THREE of Clubs
THREE of Spades
FIVE of Spades
TWO of Diamonds
TWO of Clubs
NINE of Hearts
FIVE of Hearts
SIX of Spades
TEN of Diamonds
FOURTH of Hearts
King of Hearts
Ace of Spades
THREE of Spades
NINE of Spades
King of Spades
King of Diamonds
King of Diamonds
Jack of Hearts
THREE of Clubs

.........................

Creating New Deck
.........................


Printing new full list of cards in deck
.........................
Ace of Clubs
SEVEN of Hearts
Queen of Clubs
TWO of Diamonds
King of Spades
Ace of Hearts
Ace of Spades
FOURTH of Spades
NINE of Spades
TWO of Hearts
FOURTH of Hearts
THREE of Hearts
THREE of Spades
Ace of Spades
Ace of Diamonds
Jack of Spades
TWO of Diamonds
Queen of Clubs
SIX of Hearts
TEN of Clubs
EIGHT of Diamonds
TWO of Spades
King of Hearts
TWO of Hearts
King of Hearts
NINE of Spades
FOURTH of Hearts
FIVE of Hearts
SIX of Clubs
Jack of Hearts
FOURTH of Spades
Queen of Clubs
TWO of Clubs
Ace of Clubs
NINE of Spades
TEN of Clubs
SIX of Spades
Jack of Spades
Queen of Spades
TWO of Diamonds
EIGHT of Spades
SIX of Hearts
Ace of Diamonds
FOURTH of Diamonds
Queen of Diamonds
Jack of Hearts
TWO of Clubs
FOURTH of Diamonds
SIX of Diamonds
King of Diamonds
TWO of Spades
TEN of Diamonds
.........................

Number of cards in Deck = 104
looking at one card in the deck-----SIX of Clubs
.........................

Answer 1

之后

Deck test = new Deck(new Card[52]);

你从未调用过createDeck()。顺便说一下，你的构造函数和 createDeck 有点精神 split 。您将牌组传递到构造函数中，但如果不创建新数组，则无法创建空白牌组。

编辑

1. 关于精神 split 症......

   对于 Deck 的构造函数，您有以下内容:

   公共(public)牌组(卡[]卡){ this.cards=卡片； }

   奇怪的是，我将牌组视为纸牌的集合，但你却将牌传递到牌组中。这可能只是风格问题。然而，我更希望:

   公共(public)甲板(){ 创建甲板()； }

2. createDeck() 有一个奇怪的地方，顺便说一句 - 它应该返回 int但没有返回语句。也许签名中的“void”返回会更好。我会把它设为私有(private)。如果有人想要一个新的牌组，他们应该直接使用 Deck deck = new Deck(); ，不打电话createDeck();

3. 我永远不会让 Deck 将 Cards[] 数组返回给用户。 Deck 中的数据结构和其他内部结构与任何人无关。 resetDeck()这样做。不返回 Card[] 意味着 Deck 必须提供诸如 Card getTopCard() 之类的方法。或Card getRandomCard()因为它不再“打开和服”。但这是一件好事 - 我们希望 Deck(一个非常好的名词)具有动词式的方法，允许人们操纵这副牌。

4. 我看到一个非标准循环结构:for (int b=0; b<=12; b++)这是没有错误的。然而，一般来说，循环的条件部分是不写<=的。相反，使用 <。所以我期望 for(int b=0; b<13; b++)话虽如此，当循环不以零开头时，我会忽略这个半标准。

5. 在 Card 中，我看到 public String getCardName() 。考虑稍微不同的实现。重点是通过定义数据结构而不是编写显式代码来消除代码行(从而消除错误)。看看字符串 switch 语句是如何消失的，取而代之的是一行运行时代码。 cardNames 的字符串数组是新的，但它是编译时代码，不太可能引入错误。

public class Card {
    ...
    private static final String[] cardName = new String[] {'ONE','TWO','THREE', ...etc};
    ...
    public String getCardName() {
        return cardName[cardFlippedNum];
        }

    }