c - C 中的电话簿程序将文件加载到结构数组中

Question

我在加载函数时遇到了问题，它似乎永远无法工作，我能做些什么来帮助调试此代码；注:需要将文件实际加载到结构数组中

typedef struct
    {
        char FirstName[20];
        char LastName[20];
        char StreetAddress[20];
        char Email[20];
        char PhoneNumber[20];
        char DateofBirth[20];
    }phone;

void AddEntry(phone*);
void DeleteEntry(phone*);
void LoadEntry(phone*);
void SearchForNumber(phone*);
void Modify(phone*);
void SavetoFile(phone*);
void PrintDataEntry(phone*);

int counter = 0;

char FileName[256];
FILE *f;
FILE *pWrite;

int main(void)
{   int oldp=counter;
    int p=counter;
    phone*phonebook;
    phonebook = (phone*)malloc(sizeof(phone)*100);
    int iSelection = 0;
    if (phonebook ==NULL)
    {
        printf("Out of Memory. The program will now exit\n");
        return 1;
    }
    else
    {}
        do{
                printf("%d",oldp);
            printf("\n\n\t(1)\tAdd person");
            printf("\n\t(2)\tSave added persons");
            printf("\n\t(3)\tLoad Phone book Entries");
            printf("\n\t(4)\tModify a person's data");
            printf("\n\t(5)\tSearch for Phone Number");
            printf("\n\t(6)\tDelete person");
            printf("\n\t(7)\tPrint the phone book");
            printf("\n\t(8)\tExit the phone book");
            printf("\n\nWhat would you like to do?");
            scanf("%d",&iSelection);

            switch(iSelection)
            {
                case(1):
                    {
                        AddEntry(phonebook);
                        break;
                    }
                case(2):
                    {
                        SavetoFile(phonebook);
                        break;
                    }
                case(3):
                    {
                        LoadEntry(phonebook);
                        break;
                    }
                case(4):
                    {
                        Modify(phonebook);
                        break;
                    }
                case(5):
                    {
                        SearchForNumber(phonebook);
                        break;
                    }
                case(6):
                    {
                        DeleteEntry(phonebook);
                        break;
                    }
                case(7):
                    {
                        PrintDataEntry(phonebook);
                        break;
                    }
                case(8):
                    {
                        break;
                    }
            }
        }while(iSelection <= 9);
}

void Modify(phone*phonebook)
{   int oldp=counter;
    int x = 0, i = 0;
    char searchTarget[20];
    printf("\nLast name:");
    scanf("%s",searchTarget);
    for(x=0;x<counter;x++)
    {
        if(!strcmp(searchTarget,phonebook[x].LastName))
            i = x;
    }
    if(i)
    {
        printf("\nFirst name:");
        scanf(" %[^\n]",phonebook[i].FirstName);
        printf("\nStreet Address:\n");
        scanf(" %[^\n]",phonebook[i].StreetAddress);
        printf("\nEmail:\n");
        scanf("%s",phonebook[i].Email);
        printf("\nPhone Number:\n");
        scanf("%s",phonebook[i].PhoneNumber);
    }
    else
        printf("That contact was not found, please try again.");
}

void AddEntry(phone*phonebook)
{   int oldp=counter;
    pWrite = fopen("phonebook_contacts.txt","a");
    if(pWrite == NULL)
    {
        perror("The following error occurred");
        exit(EXIT_FAILURE);
    }
    else
    {
        realloc(phonebook,sizeof(phone));
        printf("\nFirst Name:\n");
        scanf(" %[^\n]",phonebook[counter].FirstName);
        printf("\nLast Name:\n");
        scanf(" %[^\n]",phonebook[counter].LastName);
        printf("\nStreet Address:\n");
        scanf(" %[^\n]",phonebook[counter].StreetAddress);
        printf("\nEmail:\n");
        scanf("%s",phonebook[counter].Email);
        printf("\nPhone Number:\n");
        scanf("%s",phonebook[counter].PhoneNumber);
        printf("\n\tPerson was successfully added to Phonebook\n");
        fprintf(pWrite,"%s,%s,%s,%s,%s\n",phonebook[counter].FirstName,phonebook[counter].LastName,phonebook[counter].StreetAddress,phonebook[counter].Email,phonebook[counter].PhoneNumber);
        counter++;
        fclose(pWrite);
    }
}

void DeleteEntry(phone*phonebook)
{   int oldp=counter;
    int x = 0;
    int i = 0;
    char deleteFirstName[20];
    char deleteLastName[20];
    printf("\nFirst name:");
    scanf("%s",deleteFirstName);
    printf("\nLast name:");
    scanf("%s",deleteLastName);
    for(x=0;x<counter;x++)
    {
        if(strcmp(deleteFirstName,phonebook[x].FirstName) == 0)
        {
            if(strcmp(deleteLastName,phonebook[x].LastName) == 0)
            {
                for(i=x;i<counter-1;i++)
                {
                    strcpy(phonebook[i].FirstName,phonebook[i+1].FirstName);
                    strcpy(phonebook[i].LastName,phonebook[i+1].LastName);
                    strcpy(phonebook[i].PhoneNumber,phonebook[i+1].PhoneNumber);
                }
                printf("Record deleted from the phonebook.\n\n");
                --counter;
                return;
            }
        }
    }
    printf("That contact was not found, please try again.");
}

void LoadEntry(phone*phonebook)
{
    struct phone;
    FILE *f;
f=fopen("phonebook_contacts.txt","r");
if(f==NULL)
{
printf("\nfile opening error in listing :");

exit(1);
}
while(fread(&f,sizeof(f),1,f)==1)
{
     printf("\n\n\n YOUR RECORD IS\n\n ");
      printf("%s%s%s%s%s",phonebook[counter].FirstName,phonebook[counter].LastName,phonebook[counter].StreetAddress,phonebook[counter].Email,phonebook[counter].PhoneNumber);
     getch();
}
fclose(f);

}

void PrintDataEntry (phone*phonebook)
{   int oldp=counter;
    int x = 0;
    printf("\nPhonebook Entries:\n\n");
    f=fopen("phonebook_contacts.txt","r");
    if(f== NULL)
    {
        perror("The following error occurred:");
        exit(EXIT_FAILURE);
    }
    else
    {
        for(x=0;x<counter;x++)
        {
            printf("%s%s%s%s%s",phonebook[counter].FirstName,phonebook[counter].LastName,phonebook[counter].StreetAddress,phonebook[counter].Email,phonebook[counter].PhoneNumber);

        }
    }
    fclose(f);
}

void SortByDateofBirth(phone*phonebook)
{   int oldp=counter;
    int i = 0;
    int x = 0;
    int swap;
    int TempCounter = counter;
    phone Temp;
    do{
        swap = 0;
        for(i=1;i<TempCounter;i++)
        {
            if(strcmp(phonebook[i-1].DateofBirth,phonebook[i].DateofBirth)>0)
            {
                Temp = phonebook[i];
                phonebook[i] = phonebook[i-1];
                phonebook[i-1] = Temp;
                strcpy(Temp.DateofBirth,phonebook[i].DateofBirth);
                strcpy(Temp.LastName,phonebook[i].LastName);
                strcpy(Temp.PhoneNumber,phonebook[i].PhoneNumber);
                swap = 1;
            }
        }
        TempCounter--;
    }
    while(swap);
    printf("\nYour friends in Time Order by Date of Birth:\n\n");
    for(x=0;x<counter;x++)
    {
        printf("\n(%d)\n",x+1);
        printf("Name: %s %s\n",phonebook[x].DateofBirth,phonebook[x].LastName);
        printf("Number:%s\n",phonebook[x].PhoneNumber);
    }
}

void SortByLastName (phone*phonebook)
{   int oldp=counter;
    int i = 0;
    int x = 0;
    int swap;
    int TempCounter = counter;
    phone Temp;
    do{
        swap = 0;
        for(i=1;i<TempCounter;i++)
        {
            if(strcmp(phonebook[i-1].LastName,phonebook[i].LastName)>0)
            {
                Temp = phonebook[i];
                phonebook[i] = phonebook[i-1];
                phonebook[i-1] = Temp;
                strcpy(Temp.FirstName,phonebook[i].FirstName);
                strcpy(Temp.LastName,phonebook[i].LastName);
                strcpy(Temp.PhoneNumber,phonebook[i].PhoneNumber);
                swap = 1;
            }
        }
        TempCounter--;
    }
    while(swap);
    printf("\nYour friends in Alphabetical order by First Name:\n\n ");
    for(x=0;x<counter;x++)
    {
        printf("\n(%d)\n",x+1);
        printf("Name: %s %s\n",phonebook[x].FirstName,phonebook[x].LastName);
        printf("Number:%s\n",phonebook[x].PhoneNumber);
    }
}

void SearchForNumber (phone*phonebook)
{
    int x=0,*i,j=0;
    char TempLastName[20];

    printf("\nplease type the Last name of the friend you wish to find his number.");
    printf("\n\nLast Name:");
    scanf("%s",TempLastName);
    printf("\nsearch result:\n");
    for(x=0;x<counter;x++)
    {
        if(!strcmp(TempLastName,phonebook[x].LastName))
           {
            i[j] = x;
            j++;
           }
    }
    for(j=0;j<counter;j++)
    {
            printf("%s,",phonebook[i[j]].FirstName);
            printf("%s,",phonebook[i[j]].StreetAddress);
            printf("%s,",phonebook[i[j]].Email);
            printf("%s",phonebook[i[j]].PhoneNumber);
    }
}

void SavetoFile (phone*phonebook)
{   int oldp=counter;
    fprintf(pWrite,"%s,%s,%s,%s,%s\n",phonebook[counter].FirstName,phonebook[counter].LastName,phonebook[counter].StreetAddress,phonebook[counter].Email,phonebook[counter].PhoneNumber);
    oldp = counter;
}

void Quit (phone*phonebook)
{   int oldp=counter;
    fopen("phonebook_contacts.txt","r");
    if(!(oldp == counter))
        printf("The data entered isn't saved.\nAll of the changes will be discarded.");
    else
        exit(phonebook);}

退出函数不应包含任何文件名，也不应包含打印! 我无法理解如何将文件加载到结构数组中，因此如何在不泄漏太多内存大小的情况下完成此操作。

Answer 1

看一下这一行:

while(fread(&f,sizeof(f),1,f)==1)

为什么使用f两次？你的编译器没有对你尖叫吗？

f 是一个 FILE* - 它不是您可以存储数据的东西。

你是故意的吗

while(fread(&phone,sizeof(phone),1,f)==1)
             ^^^^^        ^^^^^

或pephaps

while(fread(&phonebook[counter],sizeof(*phonebook),1,f)==1)

但话又说回来，你永远不会增加计数器 ....