c - 传递结构指针的问题和 "conflicting types"错误

Question

我正在编写一个程序，根据给定的输入排列名称列表。这是我的代码

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define MAX_LEN 19 //names no longer than 19 chars
#define MAXPEOPLE 10

struct genderinfo {
    char** winning;
    char** names;
    int** scores;
};


char** allocnames(int num);
int** allocratings(int num, int num2);
void inputdata(int numpeople, struct genderinfo *male, struct genderinfo *female, FILE* fp);
void permute(int permuteset[], int k, int numpeople, struct genderinfo *male, struct     genderinfo *female, int *maxLindex);
void swap(int permuteset[],int i, int j);
void compare(int permuteset[], struct genderinfo *male, struct genderinfo *female, int *maxLindex, int numpeople);

///write free functions for struct arrays

int main () {

FILE* fp = fopen("matching.txt", "r");

struct genderinfo male;
struct genderinfo female;

//loop variables
int numdates, i, j, k;

//other variables
int numpeople, maxLindex = 0, difference;

fscanf(fp, "%d", &numdates);

for(i=1; i <= numdates; i++) {

    fscanf(fp, "%d", &numpeople);
    //printf("%d possible couples\n", numpeople);

    //allocate memory for arrays of names
    male.names = allocnames(numpeople);
    female.names = allocnames(numpeople);
    male.winning = allocnames(numpeople);
    female.winning = allocnames(numpeople);

    //allocate memory for score arrays
    male.scores = allocratings(numpeople, numpeople);
    female.scores = allocratings(numpeople, numpeople);
    int permuteset[numpeople];

    //fill permute set with 0-k, these will serve as array indexes to compare against malenames array
    //format used will be malenames[i][permuteset[i]] femalenames[permuteset[i]][i] to index the scores
    for(k=0; k<numpeople; k++)
        permuteset[k] = k;

    inputdata(numpeople, &male, &female, fp);
    permute(permuteset, 0, numpeople, &male, &female &maxLindex);

    printf("Matching #%d: Maximum Score = %d\n\n", i, maxLindex);

    for (j=0; j<numpeople; j++){

            printf("%s %s\n", male.winning[j], female.winning[j]);
    }

    printf("\n\n");

}

return 0;

}

char** allocnames(int num) {

int i;

char** names = (char**)malloc(num*sizeof(char*));

for(i=0; i < num; i++)
    names[i] = (char*)malloc(MAX_LEN+1);

return names;

}

int** allocratings(int num, int num2) {

int i;

int** ratings = (int**)malloc(num*sizeof(int*));

for(i=0; i < num; i++)
    ratings[i] = (int*)malloc(num2*sizeof(int));

return ratings;

}

void inputdata(int numpeople, struct genderinfo *male, struct genderinfo *female, FILE* fp) {

int i, j;

for (i=0; i < numpeople; i++) {
    fscanf(fp, "%s", male->names[i]);
    //printf("%s ", malenames[i]);
}

for (i=0; i < numpeople; i++) {
    fscanf(fp, "%s", female->names[i]);
    //printf("%s ", femalenames[i]);
}

for (i=0; i < numpeople; i++) {
    for (j=0; j < numpeople; j++) {
        fscanf(fp, "%d", &male->scores[i][j]);
        //printf("%d ", malescores[i]);
    }
}

for (i=0; i < numpeople; i++) {
    for(j=0; j < numpeople; j++) {
        fscanf(fp, "%d", &female->scores[i][j]);
        //printf("%d ", femalescores[i][j]);
    }
}
}

void permute(int permuteset[], int k, int numpeople, struct genderinfo *male, struct genderinfo *female, int *maxLindex) {

int i;

if (k == numpeople) {

    compare(permuteset, &male, &female, &maxLindex, numpeople);
}

else {

     // Loop through each possible starting letter for index k,
     // the first index for which we have a choice.
     for (i=k; i<numpeople; i++) {

         // Place the character stored in index j in location k.
         swap(permuteset, k, i);

         // Print out all of the permutations with that character
         // just chosen above fixed.
         permute(permuteset, 0, numpeople, &male, &female &maxLindex);

         // Put the original character that used to be there back
         // in its place.
         swap(permuteset, i, k);
     } //end i for
 } //end else

}

void swap(int permuteset[], int i, int j) {

int temp = permuteset[i];
permuteset[i] = permuteset[j];
permuteset[j] = temp;

}

//This function will take a permutation in and compare malescores[i] to
//femalescores[permuteset[i]]
//if malescores[i] > femalescores[permuteset[i]] scoresum += bla blah else if.... etc.

//copy malenames[i] and femalenames[permuteset[i]] into winning couples
//with if statements above

//malescores[i][permuteset[i]]
//femalescores[permuteset[i]][i]]
void compare(int permuteset[], struct genderinfo *male, struct genderinfo *female, int *maxLindex, int numpeople) {

int temp_maxLindex, i, j, minlike;

for(i=0; i<numpeople; i++){

    if (male->scores[i][permuteset[i]] > female->scores[permuteset[i]][i])
        minlike = female->scores[permuteset[i]][i];

    else
        minlike = male->scores[permuteset[i]][i];

    temp_maxLindex += minlike;

    if (temp_maxLindex > maxLindex) {
        maxLindex = temp_maxLindex;

        for(j=0; j<numpeople; j++){

            strcpy(male->winning[j], male->names[i]);
            strcpy(female->winning[j], female->names[permuteset[i]]);

        } //j for

    } //if

} //i for

}

我收到这些错误，其中一个与我传递到我的 inputdata 函数中的内容有关，还有一堆其他关于冲突类型的错误？我现在已经对代码进行了一些修改，但没有任何进展。此时，我只是想让代码运行，以便我可以调试算法等等，非常感谢任何帮助。

D:\School\Summer 2012\CS1\Assignments\2\main.c||In function 'main':|
D:\School\Summer 2012\CS1\Assignments\2\main.c|61|error: invalid operands to binary & (have 'struct genderinfo *' and 'int')|
D:\School\Summer 2012\CS1\Assignments\2\main.c|61|error: too few arguments to function 'permute'|
D:\School\Summer 2012\CS1\Assignments\2\main.c|17|note: declared here|
D:\School\Summer 2012\CS1\Assignments\2\main.c|35|warning: unused variable 'difference' [-Wunused-variable]|
D:\School\Summer 2012\CS1\Assignments\2\main.c||In function 'permute':|
D:\School\Summer 2012\CS1\Assignments\2\main.c|139|warning: passing argument 2 of 'compare' from incompatible pointer type [enabled by default]|
D:\School\Summer 2012\CS1\Assignments\2\main.c|19|note: expected 'struct genderinfo *' but argument is of type 'struct genderinfo **'|
D:\School\Summer 2012\CS1\Assignments\2\main.c|139|warning: passing argument 3 of 'compare' from incompatible pointer type [enabled by default]|
D:\School\Summer 2012\CS1\Assignments\2\main.c|19|note: expected 'struct genderinfo *' but argument is of type 'struct genderinfo **'|
D:\School\Summer 2012\CS1\Assignments\2\main.c|139|warning: passing argument 4 of 'compare' from incompatible pointer type [enabled by default]|
D:\School\Summer 2012\CS1\Assignments\2\main.c|19|note: expected 'int *' but argument is of type 'int **'|
D:\School\Summer 2012\CS1\Assignments\2\main.c|153|error: invalid operands to binary & (have 'struct genderinfo **' and 'int *')|
D:\School\Summer 2012\CS1\Assignments\2\main.c|153|warning: passing argument 4 of 'permute' from incompatible pointer type [enabled by default]|
D:\School\Summer 2012\CS1\Assignments\2\main.c|133|note: expected 'struct genderinfo *' but argument is of type 'struct genderinfo **'|
D:\School\Summer 2012\CS1\Assignments\2\main.c|153|error: too few arguments to function 'permute'|
D:\School\Summer 2012\CS1\Assignments\2\main.c|133|note: declared here|
D:\School\Summer 2012\CS1\Assignments\2\main.c||In function 'compare':|
D:\School\Summer 2012\CS1\Assignments\2\main.c|194|warning: comparison between pointer and integer [enabled by default]|
D:\School\Summer 2012\CS1\Assignments\2\main.c|195|warning: assignment makes pointer from integer without a cast [enabled by default]|
||=== Build finished: 10 errors, 7 warnings ===|

Answer 1

--- permute.c.OLD   2012-06-14 22:48:06.760926525 +0200
+++ permute.c   2012-06-14 22:47:37.344810744 +0200
@@ -21,7 +21,7 @@

 ///write free functions for struct arrays

-int main () {
+int main (void) {

 FILE* fp = fopen("matching.txt", "r");

@@ -32,7 +32,7 @@
 int numdates, i, j, k;

 //other variables
-int numpeople, maxLindex = 0, difference;
+int numpeople, maxLindex = 0; // difference;

 fscanf(fp, "%d", &numdates);

@@ -58,7 +58,7 @@
         permuteset[k] = k;

     inputdata(numpeople, &male, &female, fp);
-    permute(permuteset, 0, numpeople, &male, &female &maxLindex);
+    permute(permuteset, 0, numpeople, &male, &female, &maxLindex);

     printf("Matching #%d: Maximum Score = %d\n\n", i, maxLindex);

@@ -136,7 +136,7 @@

 if (k == numpeople) {

-    compare(permuteset, &male, &female, &maxLindex, numpeople);
+    compare(permuteset, male, female, maxLindex, numpeople);
 }

 else {
@@ -150,7 +150,7 @@

          // Print out all of the permutations with that character
          // just chosen above fixed.
-         permute(permuteset, 0, numpeople, &male, &female &maxLindex);
+         permute(permuteset, 0, numpeople, male, female, maxLindex);

          // Put the original character that used to be there back
          // in its place.
@@ -191,8 +191,8 @@

     temp_maxLindex += minlike;

-    if (temp_maxLindex > maxLindex) {
-        maxLindex = temp_maxLindex;
+    if (temp_maxLindex > *maxLindex) {
+        *maxLindex = temp_maxLindex;

         for(j=0; j<numpeople; j++){

摘要:缺少 kommaas、太多 & 符号、缺少星号。

我还没有检查语义错误，我认为它们仍然存在。 ( permute() 中的无界递归调用看起来很可疑)

我还建议删除 malloc() 返回值中的强制转换并使用惯用语 p = malloc N * sizeof *p); 但这会进一步增加差异的大小。