CS50 Runoff 程序正在运行，但 check50 表示没有运行

Question

所以基本上我的程序应该进行某种决选(在这里你可以看到它是什么: https://cs50.harvard.edu/x/2020/psets/3/runoff/ )。我需要实现 6 个函数才能做到这一点，我做到了。我的程序工作得很好，但 check50 说函数 print_winner 不起作用(尽管它只花费 4/24 可能的点)。如果候选人拥有所有选票的多数(>50%)，则此函数必须打印选举的候选人。该错误仅表示“当某人拥有多数票时，print_winner 必须打印姓名，print_winner 未打印选举获胜者”以及另外 3 个此类错误。

这是完整的代码:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <cs50.h>
#include <math.h>

#define MAX 9

typedef struct
{
    string name;
    int votes;
    bool eliminated;
}
candidate;

candidate candidates[MAX];

int voter_count;
int candidate_count;
int preferences[MAX][MAX];
float winner_vote;

//void check_preference(void);
bool is_tie(int min);
bool vote(int voter, int rank, string name);
bool print_winner(void);
void tabulate(void);
int find_min(void);
void eliminate(int min);


int main(int argc, string argv[])
{
    if (argc < 2)
    {
        printf("Usage: plurality [candidate ...]\n");
        return 1;
    }

    candidate_count = argc - 1;

    if (candidate_count > MAX)
    {
        printf("Maximum number of candidates is %i\n", MAX);
        return 2;
    }



    for (int i = 0; i < candidate_count ; i++)
    {
        candidates[i].name = argv[i + 1];
        candidates[i].votes = 0;
        candidates[i].eliminated = false;
    }

    voter_count = get_int("Number of voters: ");

    winner_vote = voter_count / 2;
    int integer = winner_vote;

    if (winner_vote == integer)
    {
        winner_vote++;
    }
    else
    {
        winner_vote = ceil(winner_vote);
    }

    for (int i = 0; i < voter_count; i++)
    {
        for (int j = 0; j < candidate_count; j++)
        {


            string name = get_string("Rank %i ", j + 1);

            if (!vote(i, j, name))

            {
                printf("Invalid vote\n");
                j--;
            }

        }
        printf("\n");
    }


    //check_preference();

    while (true)
    {
        tabulate();

        if (print_winner())
        {
            return 1;
        }
        else if (is_tie(find_min()))
        {
            return 1;
        }
        else
        {
            eliminate(find_min());
        }

    }
}


void eliminate(int min)
{
    for (int i = 0; i < candidate_count; i++)
    {
        if (candidates[i].eliminated)
        {
            continue;
        }
        else if (min == candidates[i].votes)
        {
            candidates[i].eliminated = true;
        }
    }

}




int find_min(void)
{
    int min = MAX;
    for (int i = 1; i < candidate_count; i++)
    {
        if (candidates[i].eliminated)
        {
            continue;
        }
        else if (min > candidates[i].votes)
        {
            min = candidates[i].votes;
        }
    }

    return min;



}


bool is_tie(int min)
{
    for (int i = 0; i < candidate_count; i++)
    {
        if (candidates[i].eliminated)
        {
            continue;
        }
        else if (min == candidates[i].votes)
        {
            continue;
        }
        else
        {
            return 0;
        }
    }
    return 1;
}




bool vote(int voter, int rank, string name)
{
    bool exist = false;



    for (int i = 0; i < candidate_count; i++)
    {
        if (strcmp(name, candidates[preferences[voter][i]].name) == 0 && rank > 0)
        {
            return 0;
        }

        if (strcmp(name, candidates[i].name) == 0)
        {

            preferences[voter][rank] = i;
            exist = true;
            break;
        }
    }

    return exist;
}







bool print_winner(void)
{
    // candidate candidateHolder;
    for (int f = 0; f < candidate_count; f++)
    {
        //candidateHolder = candidates[f];
        if (candidates[f].votes >= winner_vote)
        {
            printf("%s\n", candidates[f].name);
            return 1;
        }

    }
    return 0;
}

void tabulate(void)
{
    int check = 0;
    for (int i = 0; i < voter_count; i++)
    {
        if (!candidates[preferences[i][check]].eliminated)
        {
            candidates[preferences[i][check]].votes++;
            check = 0;
        }
        else
        {
            check++;
            i--;
        }
    }
}

这是产生错误的函数:

bool print_winner(void)
{
    // candidate candidateHolder;
    for (int f = 0; f < candidate_count; f++)
    {
        //candidateHolder = candidates[f];
        if (candidates[f].votes >= winner_vote)
        {
            printf("%s\n", candidates[f].name);
            return 1;
        }

    }
    return 0;
}

Answer 1

看来你忘记了“如果任何候选人获得多数(超过 50%)第一优先选票，则该候选人将被宣布为选举获胜者。”