c - win 检查功能在用 c 编写的连接四中无法正常工作；

Question

已关闭。此问题需要 debugging details 。目前不接受答案。

---

编辑问题以包含 desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem 。这将有助于其他人回答问题。

已关闭 3 年前。

Improve this question

嘿大家好，我刚刚开始学习 C，我的老师给了我一个作业来创建连接四的版本；一切都很好，除了玩家一号左下角的wincheck，代码是相同的，但由于某种原因，它无法识别玩家一号左下角的二甘醇，我不明白为什么这是我到目前为止所得到的(请注意，有些函数是老师亲自给我的，所以他们的定义有点缺乏):

#define _CRT_SECURE_NO_WARNINGS
#include "stdio.h"
#include<stdbool.h>
#include "stdlib.h"
#define MAXturns 42
#define ROWS 6
#define COLS 7
char board[ROWS][COLS];

void printboard();


char playerswap(int i);

int inputprint(int colp, char apropriate);

int wincheck(int row, int col);

void initBoard();

char getCell(int row, int col);

void setCell(int row, int col, char sign);

void clearScreen();
int main()
{
    int i, col = 0,clonerow=0;
    initBoard();
    printboard();
    printf("\n");
    for ( i = 0; i <=MAXturns ; i++)  
    {
        if (i==MAXturns)
        {
            printf("it's a tie try again\n");
            system("pause");
            clearScreen();
            initBoard();
            printboard();
            i = 0;
        }
        if (playerswap(i) == 'X') 
        {
            printf("\nPlayer1:\nPlease enter a column number between 1-7:\n");
        }
        else
        {
            printf("\nPlayer2:\nPlease enter a column number between 1-7:\n");
        }
        scanf("%d", &col);
        if (col > 0 && col <= COLS)
        {
            if (getCell(1, col) != ' ')
            {
                printf("no room please try another column.\n");
                i--;
            }
            else
            {
                clonerow=inputprint(col, playerswap(i));
                clearScreen();
                printboard();
                printf("\n");
            }
        }
        else
        {
            printf("non applicable input\n");
            i--;
        }
        if (wincheck(clonerow,col)==1)
        {
            printf("\nplayer 1 you'r the winner!!!!\n");
            system("pause");
            break;
        }
        else
        {
            if (wincheck(clonerow,col)==2)
            {
                printf("\nplayer 2 you'r the winner!!!!\n");
                system("pause");
                break;
            }
        }
    }
    return 0;
}

char getCell(int row, int col)
{
    return board[row - 1][col - 1];
}

void setCell(int row, int col, char sign)
{
    board[row - 1][col - 1] = sign;
}

void initBoard()
{
    int i, j;

    for (i = 0; i < ROWS; i++)
    {
        for (j = 0; j < COLS; j++)
        {
            setCell(i + 1, j + 1, ' ');
        }
    }
}

void clearScreen()
{
    system("cls");
}
    void printboard()
{
        int i, j, y_col = 1;
        for (i = 0; i <= ROWS; i++)
        {
            if (i == 0)
            {
                for (j = 1; j <= COLS; j++)
                    printf("  %d", j);
            }
            else
            {
                printf("\n");
                printf("%c", i+64);
                for (y_col = 1; y_col <= COLS; y_col++)
                {
                    if (y_col == 1)
                    {
                        printf(" %c", getCell(i, y_col));
                    }
                    else
                    {
                    printf("  %c", getCell(i, y_col));
                    }
                }
            }
        }
    }
    int wincheck(int row,int col)
    {
        int i = 1, j = 1;
        for (i = 1; i <= 4; i++)
        {
            if (getCell(row, i) == 'X' && getCell(row, i + 1) == 'X' && getCell(row, i + 2) == 'X' && getCell(row, i + 3) == 'X')
            {
            return 1;
            }
            else
            {
            if (getCell(row, i) == 'O' && getCell(row, i + 1) == 'O' && getCell(row, i + 2) == 'O' && getCell(row, i + 3) == 'O')
                {
                return 2;
                }
            }
        }
        if (row <= 3)
        {
            for (j = 1; j <= 3; j++)
            {
                if (getCell(j, col) == 'O' && getCell(j + 1, col) == 'O' && getCell(j + 2, col) == 'O' && getCell(j + 3, col) == 'O')
                {
                return 2;
                }
                if (getCell(j, col) == 'X' && getCell(j + 1, col) == 'X' && getCell(j + 2, col) == 'X' && getCell(j + 3, col) == 'X')
                {
                return 1;
                }
            }
        }
        if (getCell(row,col)=='X'&&getCell(row-1,col-1)=='X'&&getCell(row-2,col-2)=='X'&&getCell(row-3,col-3)=='X')
        {
            return 1;
        }
        if (getCell(row, col) == 'X' && getCell(row - 1, col + 1) == 'X' && getCell(row - 2, col + 2) == 'X' && getCell(row - 3, col + 3) == 'X')\\this is the part that doesn't work for some reason 
        {
            return 1;
        }
        if (getCell(row, col) == 'X' && getCell(row+1, col - 1) == 'X' && getCell(row+2, col - 2) == 'X' && getCell(row+3, col - 3) == 'X')
        {
            return 1;
        }

        if (getCell(row, col) == 'O' && getCell(row+1, col + 1) == 'O' && getCell(row+2, col + 2) == 'O' && getCell(row+3, col + 3) == 'O')
        {
            return 2;
        }
        if (getCell(row, col) == 'O' && getCell(row - 1, col - 1) == 'O' && getCell(row - 2, col - 2) == 'O' && getCell(row - 3, col - 3) == 'O')
        {
            return 2;
        }
        if (getCell(row, col) == 'O' && getCell(row - 1, col + 1) == 'O' && getCell(row - 2, col + 2) == 'O' && getCell(row - 3, col + 3) == 'O')
        {
            return 2;
        }
        if (getCell(row, col) == 'O' && getCell(row + 1, col - 1) == 'O' && getCell(row + 2, col - 2) == 'O' && getCell(row + 3, col - 3) == 'O')
        {
            return 2;
        }
        if (getCell(row, col) == 'O' && getCell(row + 1, col + 1) == 'O' && getCell(row + 2, col + 2) == 'O' && getCell(row + 3, col + 3) == 'O')
        {
            return 2;
        }
    }

    int inputprint(int colp, char apropriate) {
        int i;
        for (i = 1; i <= ROWS; i++)
        {
            if (getCell(i, colp) != ' ')
            {
                setCell(i - 1, colp, apropriate);
                break;
            }
            else
            {
                if (i == ROWS)
                    setCell(i, colp, apropriate);
            }
        }
        return i-1;
    }
    char playerswap(int i)
    {
        if (i % 2 == 0)
            return 'X';
        else
            return 'O';
    }
---

Answer 1

一个明显的问题是，这段代码的数组索引似乎比 C 语言允许的更加自由。
C使用zero based indexing for arrays 。例如，这样的数组:

int array[10]; //has room for 10 integer values, accessed like this:

for(int i=0;i<10;i++)
{
    array[i] = i;  //populates array[0] through array[9]
}

例如。对于:

#define ROWS 6
#define COLS 7
char board[ROWS][COLS];

 ...

    for (i = 1; i <= 4; i++)
    {
        if (getCell(row, i) == 'X' && getCell(row, i + 1) == 'X' && getCell(row, i + 2) == 'X' && getCell(row, i + 3) == 'X')

数组索引实际上应该是:

    for (i = 0; i < 7; i++)
    {     
        if (getCell(row, i) == 'X' && getCell(row, i + 1) == 'X' && getCell(row, i + 2) == 'X' && getCell(row, i + 3) == 'X')

在本节中，row - 3 在某些时候会是负值，导致数组索引为负，这可能是您遇到的问题:

   if (getCell(row, col) == 'X' && getCell(row - 1, col + 1) == 'X' && getCell(row - 2, col + 2) == 'X' && getCell(row - 3, col + 3) == 'X')
    {
        return 1;
    }