Java-根据用户输入更新类的返回数据

Question

我不太确定在标题中陈述问题的更好/更清晰的方式，所以请原谅我。

我目前正在尝试做的是根据用户的输入更改变量的值。目前我可以根据输入设置一个值，但是我的程序需要一个循环，用户必须在其中多次输入。

我遇到的问题是，当我调用该类时，它只返回第一个输入的相关数据。因此，虽然用户可以继续进行不同的输入，但数据永远不会在第一次输入之后更新。

import java.util.Scanner;

public class Hw6Wargolet {
   public static void main(String[] args) {
    Scanner keyboard = new Scanner (System.in); 
    String buddyName;
    String userChoice;

    System.out.print("Nurse: The Patient's first name is ");
    buddyName = keyboard.nextLine();

    System.out.print("You: Let's see, I should (C)hange " + buddyName + "'s bandages," +
                       "(G)ive " + buddyName + " pain medication, " + 
                    "(A)dd antibiotics to " + buddyName + "'s I.V," +
                    " or (D)ischarge " + buddyName + " ");

     userChoice = keyboard.nextLine();

     Buddy score = new Buddy(userChoice);
     BuddyScore finalScore = new BuddyScore();
     //the loop. essentially repeating the prompt for input until a score is reached
     do{
        System.out.print("You: Let's see, I should (C)hange " + buddyName + "'s"
                + " bandages, (G)ive " + buddyName + " pain medication, " + 
                    "(A)dd antibiotics to " + buddyName + "'s I.V," +
                    " or (D)ischarge " + buddyName + " ");

        userChoice = keyboard.nextLine();

        System.out.println(score.getBuddyScore());
        System.out.println(finalScore.getFinalScore());
    }while(finalScore.getFinalScore() < 5);

   }

}

下面是我的类，它返回数据/值。

public class Buddy {
    private String userChoice;
    public int buddyScore;  

    public Buddy(String userChoice){
        this.userChoice = userChoice;
    }

    public void setUserChoice(String userChoice){
        this.userChoice = userChoice;
    }

    public String getUserChoice(){
        return userChoice;
    }

    public void setBuddyScore(int buddyScore){
        buddyScore = buddyScore;
    }

    public int getBuddyScore(){
        switch (userChoice){
            case "C":
              buddyScore = 1;
              break;
            case "G":
              buddyScore = -2;
              break;
            case "A":
              buddyScore = 3;
              break;
            case "D":
              buddyScore = 7;
              break;
            default:
              buddyScore = 0;
              break;
        };
        return buddyScore; 
    }

}

此外，下面是获取每个输入分数并加/减总分的类

public class BuddyScore {
   public int finalScore;
   private int buddyScore;

   public BuddyScore(){
      this.finalScore = finalScore;
      this.buddyScore = buddyScore;
   }

   public BuddyScore(Buddy object2){
      buddyScore = object2.getBuddyScore();
   }


   public void setFinalScore(int finalScore){
      this.finalScore = finalScore;
   } 

   public int getFinalScore(){
     return finalScore += buddyScore; 
   }    
}

任何意见、提示、建议将不胜感激。谢谢。

Answer 1

我注意到三件事:

1)

在你的 Buddy 类中，在方法 setBuddyScore(int buddyScore) 中你做

buddyscore = buddyscore;

代替

this.buddyscore = buddyscore;

(可能导致成员变量和参数的混淆)

2)(编辑)

在您的主类中，新的 userChoice 没有任何变化。也许你可以这样做:

首先更改 BuddyScore 类，使其存储整个 Buddy 对象，而不仅仅是分数。这样，BuddyScore 对象就可以知道 Buddy 对象发生了哪些变化。然后您需要在 getFinalScore() 中调用 getBuddyScore() 方法以始终添加当前分数。

public class BuddyScore {
    private Buddy buddyScore;

    public BuddyScore(Buddy buddyScore) {
        this.buddyScore = buddyScore;      // here you store the 'reference' of your Buddy object
    }

    public int getFinalScore() {
        return finalScore += buddyScore.getBuddyScore();  // here you retrieve the most recent 'buddyScore' from your 'Buddy' object and add it to the finalScore
    } 
}

然后回到你的主类，你所需要的就是更新 Buddy 对象(在循环内)以始终知道最新的 userChoice:

do {
    // stuff
    userChoice = keyboard.nextLine();
    score.setUserChoice(userChoice);
}while (finalScore.getFinalScore() < 5);   // here your finalScore object will add the recent score from the buddy class to the final score 

这确实有效。但请注意，您的最终分数只会在您调用 getFinalScore() 时更新......也许您应该引入另一种方法来进行更新并让 getFinalScore() 仅返回已经计算出的最终分数。