javascript api简化

Question

使用 fourquare api 获取 field ，之前有一个从 api 中写出的可点击列表，但将其缩减为仅将一个 field 名称写入屏幕。然后决定最好将它发送到 php。因此，当我执行我认为合乎逻辑的代码切割时，它完全停止工作了。

我的程序有这个，工作:

$(document).ready(function doEverything(element) {
    $.getJSON("https://api.foursquare.com/v2/venues/search?ll=" + lat + "," + lng + "&client_id=L2VWBKPOW45D5X3FJ3P4MJB5TGVJ4ST2J005RIVAFIWG44ND%20&client_secret=ZKDAOLHASCA31VUOGMBTAS3RFYUOMXL4IFFYPRURIDQA3QMA%20&v=20111107", function(data) {
        one = data.response.venues[0].name;
        var list = [];
        list[0] = [one];

        function Make() {
            for (var i = 0; i < 1; i++) {
                var div = document.createElement("div");
                div.style.margin = "-435px 100px 0px 110px";
                div.innerHTML = list[i];
                !
                function() {
                    var index = 0;
                    div.onclick = function() {
                        doSomething(this);
                    };
                }();
                document.body.appendChild(div);
            }
        }

        function doSomething(element) {
            var value = element.innerHTML;
            switch (value) {
            case one:
                break;
            }
        }
        Make();
    });
});

然后我决定我想使用这个将一个变量传递给 php:

theVar = 10; //just to make things simple.
urlString = "cookiestesttwo.php?var=" +theVar;
window.location = urlString;

所以我尝试将我的 api 代码简化为这样，但它停止工作了:

$(document).ready() {
    $.getJSON("https://api.foursquare.com/v2/venues/search?ll=" + lat + "," + lng + "&client_id=L2VWBKPOW45D5X3FJ3P4MJB5TGVJ4ST2J005RIVAFIWG44ND%20&client_secret=ZKDAOLHASCA31VUOGMBTAS3RFYUOMXL4IFFYPRURIDQA3QMA%20&v=20111107", function(data) {
        one = data.response.venues[0].name;
        document.write(one)
        theVar = one
        urlString = "cookiestesttwo.php?var=" + theVar;
        window.location = urlString;)
    };
};​

Answer 1

$(document).ready() { 语法不正确，会引发错误。

此外，函数末尾还有另一个语法错误。你颠倒了 } 和 )

$(document).ready(function() {
    $.getJSON("https://api.foursquare.com/v2/venues/search?ll=" + lat + "," + lng + "&client_id=L2VWBKPOW45D5X3FJ3P4MJB5TGVJ4ST2J005RIVAFIWG44ND%20&client_secret=ZKDAOLHASCA31VUOGMBTAS3RFYUOMXL4IFFYPRURIDQA3QMA%20&v=20111107", function(data) {
        one = data.response.venues[0].name; // if one is local to this function then use VAR otherwise you'll leak it globally.
        document.write(one);
        theVar = one; // same here for the VAR keyword.
        urlString = "cookiestesttwo.php?var=" + theVar; // and here as well. NO GLOBAL LEAKS!
        window.location = urlString;
    });
});

我在评论中提出了更多提示。