html - 可以改进/缩短以下使用 CodeIgniter 的 SQL 或 HTML 代码以提高可读性吗？

Question

以下代码段可以工作，但我觉得可以通过缩短来进一步改进它，从而提高效率，但我正在努力思考可以修改哪些内容。

下面是代码。

function get_student_stakeholder_refs($debate_id) {
     $sql1    = "SELECT
              b.id            AS debates_id,
              c.id            AS stakeholder_id,
              a.student_id    AS student_id
            FROM
              debate_groups a
              inner join debates b ON a.debate_id = b.id
              inner join debate_stakeholders c ON a.stakeholder_id = c.id
            WHERE
              b.starter_pack_id = c.starter_pack_id AND 
              a.debate_id = b.id AND 
              b.id = ? AND 
              a.student_id = ?";
    $rslt = $this->db->query($sql1, array($debate_id, $this->get_user_id()))->row();
    if(count($rslt)!= 0){
        $sql2  = "SELECT * FROM debate_stakeholder_profiles WHERE stakeholder_id = ?";
        return $this->db->query($sql2, array($rslt->stakeholder_id))->result_array();
    }
}

Is there a way to combine the following SQL statements into a single SQL statement so that it's easier to read?

Answer 1

在我看来，您不需要第二个 SQL 语句，因为您可以在第一个语句的连接中获取整行。只需替换这个:

c.id            AS stakeholder_id,

这样:

c.*