java - 如何重构这个验证方法

Question

我下面有很多重复的代码。我在想是否有办法清理它并删除大量重复的代码。我想我应该创建一个方法来进行日志记录并抛出异常？但是我无法思考如何去做

  for (Shape shape : Shapes) {
        if (shape.getShapeName().isEmpty()) {
            final String mesg = String.format("Empty Shape.");
            log.error(mesg);
            throw new Exception(mesg);
        }

        invalidChar = p.matcher(shape.getShapeName()).find();

        if (invalidChar) {
            final String mesg = String.format("Invalid character(s) in Shape name %s",
                    shape.getShapeName());
            log.error(mesg);
            throw new Exception(mesg);
        }

        if (shape.getShapeDesc().isEmpty() || shape.getShapeDesc().trim().length() == 0) {
            final String mesg = String.format("Empty Shape description.");
            log.error(mesg);
            throw new Exception(mesg);
        }

        if (Character.isWhitespace(shape.getShapeDesc().charAt(0))) {
            final String mesg = String.format("Empty first character in Shape description %s", shape.getShapeDescription());
            log.error(mesg);
            throw new Exception(mesg);
        }

        p = Pattern.compile("[^a-zA-Z0-9]+");
        invalidChar = p.matcher(shape.getShapeDesc()).find();

        if (invalidChar) {
            final String mesg = String.format("Invalid character in Shape description %s", shape.getShapeDesc());
            log.error(mesg);
            throw new Exception(mesg);
        }
    }

Answer 1

您可以编写一个方法，它接受两个参数，一个 boolean 值和一个字符串，并在该方法中调用带有日志记录和错误抛出的条件

void checkError(boolean condition, String message) {
    if(condition) {
        log.error(message);
        throw new Exception(message);
    }
}

然后您可以使用

代替您的条件

checkError(shape.getShapeName().isEmpty(), "Empty Shape.");