javascript - 根据参数不同条件不同

Question

如何针对这两种情况优化 processAllJobs 函数(fixAllJobs、logAllJobs)。

processAllJobs = (channel) => {
    const jobsCopy = [...this.getState().jobs];
    let validJobs = [];
    jobsCopy.forEach((job) => {
        if (channel === 'fixJobs') {
            if (job.processStatus !== ERROR && job.processStatus !== FIXED) {
                job.processStatus = IN_PROCESS;
                job.progress = 0;
                validJobs.push(job);
            }
        }  else {
            if (job.processStatus !== ERROR) {
                job.processStatus = IN_PROCESS;
                job.progress = 0;
                validJobs.push(job);
            }
        }
    });
    this.setState({isRunning: true, jobs: jobsCopy});
    ipcRenderer.send(channel, validJobs);
};

fixAllJobs = () => {
    this.processAllJobs('fixJobs');
};

logAllJobs = () => {
    this.processAllJobs('logJobs');
};

我刚刚想出这个，但这完全是无稽之谈。在 if 条件中编写三元运算符是一个好方法吗？

if (channel === 'fixJobs' ? job.processStatus !== ERROR
&& job.processStatus !== FIXED : job.processStatus !== ERROR) {
      job.processStatus = IN_PROCESS;
      job.progress = 0;
      validJobs.push(job);
}

Answer 1

您希望仅当 channel 为 fixJobs 时才检查条件 job.processStatus !== FIXED，您可以编写如下条件来实现该目的

job.processStatus !== 错误 && ( channel !== 'fixJobs' || job.processStatus !== 已修复)