java继承的最佳实践？

Question

我有以下类(class)。

public class BaseRequest {
    protected List<Emp> names;  // names property is required in many classes 
}

public class FirstRequest extends BaseRequest {

    public FirstRequest() {
        names = new ArrayList<Emp>();
    }

    public setNames(List<Emp> names){
        super.names = names;
    }

    public List<Emp> getNames(){
        return super.names;
    }
}

public class ServiceClass {

    public void someMethod(List<Emp> emps) {
        FirstRequest request = new FirstRequest();
        request.setNames(emps);
        //Some Logic
    }
}

我是否以正确的方式进行继承？我怎样才能进一步改进它？

谢谢!

Answer 1

How i can i improve it further?

将与names相关的方法移至基类中，并将names设为private。

public class BaseRequest {
    private List<Emp> names = new ArrayList<Emp>();

    public setNames(List<Emp> names){
        this.names = names;
    }

    public List<Emp> getNames(){
        return names;
    }
}

public class FirstRequest extends BaseRequest {
    // the rest of your stuff
}

您应该避免使名称 protected :公共(public) getter 对于派生类和该类的其他用户来说应该足够好了。