java - 直接从 Spring Controller 返回 byte[] 是否会造成内存泄漏？

Question

我在 Spring Controller 中有这个方法，我想确保不会造成内存泄漏。是还是不是？

@ResponseBody
@RequestMapping(value = "/document/{id}/{filename:.*}", method = RequestMethod.GET)
public byte[] getDownloadEclaimsDocument(@PathVariable("id") final String id, @PathVariable("filename") final String fileName, final HttpServletResponse response) {
    final DmsFile dmsFile = dmsService.getByFileSystemId(id);
    response.setContentType(dmsFile.getContentType());
    // This call gets a byte[] from a backend service
    return dmsService.getFileAsByteArray(dmsFile);
}

Answer 1

也许更好地使用org.springframework.core.io.Resource？

@ResponseBody
@RequestMapping(value = "/document/{id}/{filename:.*}", method = RequestMethod.GET)
public Resource getDownloadEclaimsDocument(@PathVariable("id") final String id, 
        @PathVariable("filename") final String fileName, 
        final HttpServletResponse response,) {
    final DmsFile dmsFile = dmsService.getByFileSystemId(id);
    byte[] data = dmsService.getFileAsByteArray(dmsFile);

    response.setContentType(dmsFile.getContentType());
    response.setContentLength(data.length);
    response.setHeader("Content-Disposition", 
                       "attachment; filename=\"" +
                       MimeUtility.encodeWord(dsmFile.getName(), "utf-8", "Q") + "\"");

    // This call gets a byte[] from a backend service
    return new ByteArrayResource(data);
}