c - 排序字符串不能正常工作

Question

我有这样的 rjecnik.txt 文件

mate sime, jure
stipica gujo, prvi
ante mirkec
goran maja, majica
avion kuca, brod, seoce
amerika, neka, zemlja, krcma
brodarica, zgrada, zagreb
zagreb split
zadar rijeka
andaluzija azija

我需要按字母顺序(而不是单词)对行进行排序，但我的程序产生了这个不正确的结果:

andaluzija azijamate sime, jure
amerika, neka, zemlja, krcma
brodarica, zgrada, zagreb
ante mirkec
avion kuca, brod, seoce
goran maja, majica
stipica gujo, prvi
zadar rijeka
zagreb split

按 [Enter] 关闭终端 ...当我使用非 ascii 字符，如 kuća 表示 kuca 或 krčma 表示 krcma 时，它会产生这个结果(全错)

andaluzija azijamate sime, jure
amerika, neka, zemlja, krŔma
brodarica, zgrada, zagreb
ante mirkec
avion kuŠa, brod, seoce
goran maja, majica
stipica gujo, prvi
zadar rijeka
zagreb split

按 [Enter] 关闭终端 ...这是我的代码:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
int main()
{
    int ch, nl = 1, min, lenght1, lenght2, lenght;//ch will hold characters, min is for selection sort, lenght holds value of strlen for determine wthat line is longer
    FILE * fp;// FILE pointer
    char * lines[1000];//that will dynamically hold strings for lines
    char * temp;//for lines swaping
    if((fp = fopen("C:\\Users\\don\\Documents\\NetBeansProjects\\proba2\\dist\\Debug\\MinGW-Windows\\rjecnik.txt", "r")) == NULL)//I had to temporarily put full path to rjecnik.txt
    {
        printf("Can't open file...");
        exit(1);
    }
    while((ch = getc(fp)) != EOF)//count lines
    {
        if(ch == '\n')
            nl++;
    }
    int i, j;
    for (i = 0; i < nl; i++)
        lines[i] = malloc(1000);//create array of string size value of nl
    fseek(fp, 0L, SEEK_SET);//go to start of file
    i = 0;
    j = 0;
    while((ch = getc(fp)) != EOF)//fill arrays of string
    {
        lines[i][j] = ch;
        j++;
        if(ch == '\n')
        {
           j = 0;
           i++;
        }
    }
    for(i = 0; i < nl - 1; i++)//selection sort doesn't work properly
    {
        min = i;//min is i
        for(j = i + 1; j < nl; j++)//for number of lines(nl) times
        {
            lenght1 = strlen(lines[i]);//find what string is longer and lenght is smaller one
            lenght2 = strlen(lines[j]);
            if(lenght1 < lenght2)
                lenght = lenght1;
            else
                lenght = lenght2;
            if(strncmp(lines[i], lines[j], lenght) > 0 )//compare two strings
                 min = j;//if second string is alphabetically smaller min is j
        }
        temp = lines[i];// swapping
        lines[i] = lines[min];
        lines[min] = temp;
    }
    for(i = 0; i < nl; i++ )//printing to console
    {
        lenght1 = strlen(lines[i]);
        for(j = 0; j < lenght1; j++ )
        {
            putchar(lines[i][j]);
        }
    }
    return 0;
}

现在当我添加这段代码时程序在最后崩溃了:

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
int main()
{
    int ch, nl = 1, min, lenght1, lenght2, lenght;//ch will hold characters, min is for selection sort, lenght holds value of strlen for determine wthat line is longer
    FILE * fp;// FILE pointer
    char * lines[1000];//that will dynamically hold strings for lines
    char * temp;//for lines swaping
    if((fp = fopen("C:\\Users\\don\\Documents\\NetBeansProjects\\proba2\\dist\\Debug\\MinGW-Windows\\rjecnik.txt", "r")) == NULL)//I had to temporarily put full path to rjecnik.txt
    {
        printf("Can't open file...");
        exit(1);
    }
    while((ch = getc(fp)) != EOF)//count lines
    {
        if(ch == '\n')
            nl++;
    }
    int i, j;
    for (i = 0; i < nl; i++)
        lines[i] = malloc(1000);//create array of string size value of nl
    fseek(fp, 0L, SEEK_SET);//go to start of file
    i = 0;
    j = 0;
    while((ch = getc(fp)) != EOF)//fill arrays of string
    {
        lines[i][j] = ch;
        j++;
        if(ch == '\n')
        {
           j = 0;
           i++;
        }
    }
    for(i = 0; i < nl - 1; i++)//selection sort doesn't work properly
    {
        min = i;//min is i
        for(j = i + 1; j < nl; j++)//for number of lines(nl) times
        {
            lenght1 = strlen(lines[i]);//find what string is longer and lenght is smaller one
            lenght2 = strlen(lines[j]);
            if(lenght1 < lenght2)
                lenght = lenght1;
            else
                lenght = lenght2;
            if(strncmp(lines[min], lines[j], lenght ) > 0 )//compare two strings
                 min = j;//if second string is alphabetically smaller min is j
        }
        temp = lines[i];// swapping
        lines[i] = lines[min];
        lines[min] = temp;
    }
    for(i = 0; i < nl; i++ )//printing to console
    {
        lenght1 = strlen(lines[i]);
        for(j = 0; j < lenght1; j++ )
        {
            putchar(lines[i][j]);
        }
    }
   for (i = 0; i < 100; i++)//Program crashes here
        free(lines[i]);

    return 0;
}

Answer 1

1.- 您必须在 malloc 之后将行初始化为 0，这样 strlen 才能正常工作。2.- 比较 lines[j] 和 lines[min]3.- 不要忘记免费线路