ruby - 用 ruby​​ 写了 TicTacToe，电脑玩的不爽

Question

基本上 computer_make_move 方法很简单。我只是想让它选择一个开放位置并接受它。它本来就是愚蠢的。这并不意味着要熟练地演奏(还)。

问题是出于某些不合理的原因。每次我走一步，电脑都会随机移动。有时是 1，有时是 3 或 6。只是奇怪的行为。我不明白为什么。

请注意，在 gameart.rb 文件中对此处未显示的方法的任何引用都包含在内，例如。 you_win 只是艺术，完全没有逻辑。

这里是所有的代码:

class TicTacToe
  require 'colorize'
  require_relative 'lib/gameart.rb'

  attr_reader :home_screen_ninja_art
  WINS = [[1, 2, 3], [4, 5, 6], [7, 8, 9], [1, 5, 9], [3, 5, 7], [1, 4, 7], [2, 5, 8], [3, 6, 9]]
  @@scoreboard = {player: 0, computer: 0, tie: 0}

  def initialize name, mark
    @name, @gameover, @game_memory, @winner = name, false, ['_','_','_','_','_','_','_','_','_'], ''
    mark == 'X' ? (@player, @computer = 'X', 'O') : (@player, @computer = 'O', 'X')
  end

  def menu i
    return render_board if i == 99
    return about if i == 100
    return how_to_play if i == 200
    return scoreboard if i == 300
    return goodbye if i == 400
  end

  def action move
    return menu(move) if move > 10
    current_caller = caller[0] =~ /computer_make_move/ ? @computer : @player
    i = move-1

    if @game_memory[i] == '_'
      render_board(i, current_caller)
    else
      try_again_art
    end
  end

  def computer_make_move
    action(current_board_positions[2].sample+1) # just pick any random open space for now
  end

  def render_board input=nil, caller=nil
    if @gameover == false && !input.nil?
      @game_memory[input] = caller
      verify_game_state
    end
    if @gameover == true
      game_over_art
      case 
      when @winner == 'TIE' then you_tied
      when @winner == @player then you_win
      when @winner != @player then you_lose
      end
    end

    board = @game_memory.map {|ps| ps == 'X' ? ps.colorize(:blue) : ps.colorize(:green) }.map {|ps| ps.gsub(/_/, " ")}
    show_board board
  end

  def current_board_positions
    x_positions, o_positions = [], []
    @game_memory.select.with_index do |v,i| 
      x_positions << i+1 if v == 'X'
      o_positions << i+1 if v == 'O'
    end
    open_positions = (1..9).to_a - (x_positions + o_positions)
    [x_positions, o_positions, open_positions]
  end

  def verify_game_state
    x, o, open = current_board_positions
    find_winner = ->side { WINS.map {|win| side.combination(3).to_a.map {|set| set == win }.include? true } }
    case
    when (find_winner.(x).include? true)
      @gameover=true      
      @winner='X'
    when (find_winner.(o).include? true)
      @gameover=true
      @winner='O'
    when !@game_memory.include?('_')
      @gameover=true
      @winner='TIE'
    else 
      computer_make_move
    end
  end
end

这是我初始化游戏的方式:

# Start a game 
def start_new_game name, mark
  @f = TicTacToe.new(name, mark)
  puts @f.action 99

  loop do
    if @f.instance_variable_get :@gameover
      puts 'Ready to play again?'.colorize(:white).on_red
      print '   y|yes   '.colorize(:green)
      print '   n|no   '.colorize(:red)
      valid = false
      until valid
        startover = gets.chomp
        valid = true if startover =~ /y|n|yes|no/i  
      end
      if startover =~ /y|yes/i 
        start_new_game name, mark
      else
        @f.goodbye
      end 
    else
      print "*  "
      puts "Make your move #{name}:".colorize(:white).on_red
    end

    move = gets.chomp
    puts @f.action move.to_i
  end
end

valid = false
until valid
TicTacToe.home_screen_ninja_art
puts 'What is your name?'.colorize(:white).on_red
  name = gets.chomp
  valid = true if name.length > 1
end

valid = false
until valid
TicTacToe.home_screen_ninja_art
puts 'Pick your mark?'.colorize(:white).on_red
  print '   X   '.colorize(:blue) 
  print '   O   '.colorize(:green) 
  puts ''
  mark = gets.chomp.upcase
  if mark =~ /X|O/i
    valid = true
  end
end

start_new_game name, mark

Answer 1

在每个 render_board 之后调用的方法 verify_game_state 中没有人移动的情况。它只有获胜者或平手，或者 computer_make_move，因此只有计算机不应该采取行动。

因此，每次游戏未结束时，计算机都会采取行动，直到结束，正如我所见。