ios - 内存泄漏，MutableArray 中的对象没有释放？

Question

Xcode 告诉我下面的代码在内存泄漏方面存在一些问题。

@property (nonatomic, retain) NSMutableArray *naw_rows;

-(void) loadTableRows:(BOOL)shouldReload
{
    [naw_rows removeAllObjects];

  [self.naw_rows addObject: [[CellModel alloc] initialize:@"name"     title:@"Name"          value: self.currentProfile.name]];
  [self.naw_rows addObject: [[CellModel alloc] initialize:@"company"  title:@"Company name"  value: self.currentProfile.company]];
  [self.naw_rows addObject: [[CellModel alloc] initialize:@"address"  title:@"Address"         value: self.currentProfile.address]];
  [self.naw_rows addObject: [[CellModel alloc] initialize:@"zipcode"  title:@"Zipcode"      value: self.currentProfile.zipcode]];
  [self.naw_rows addObject: [[CellModel alloc] initialize:@"city"     title:@"City"        value: self.currentProfile.city]];
}

// here is my cellModel object:
@implementation CellModel

-(id) initialize:(NSString *)newName title:(NSString *)newTitle value:(NSString *)newValue;
{
    if (self == [super init])
    {
        name = newName;
        title = newTitle;
        value = newValue;
    }
    return self;
}

- (NSString *) getName
{
   return name;
}

- (NSString *) getTitle
{
    return title;
}

- (NSString *) getValue
{
    return value;
}

-(void)dealloc
{
    [super dealloc];
}

@end;

所有的 addObject 行都给出了以下错误:

Potential leak of an object allocated on line -- Method returns an Objective-C object with a +1 retain count (owning reference) Object allocated on line -- is not referenced later in this execution path and has a retain count of +1 (object leaked)

在有关内存泄漏的其他主题中，我发现这是执行此操作的正确方法:

CellModel *model = [[CellModel alloc] initialize:@"name" title:@"Name" value: self.currentProfile.name];
[self.naw_rows addObject: model];
[model release];

但这给了我以下错误:

Incorrect decrement of the reference count of an object that is not owned at this point by the caller

那我做错了什么？在我的第一段代码中，保留计数应该是 1。由数组拥有。我假设当我使用 [array remodeAllObjects] 时对象被释放

提前致谢

妮可

Answer 1

这泄漏了:

[self.naw_rows addObject: [[CellModel alloc] initialize:@"name"     title:@"Name"          value: self.currentProfile.name]];

您拥有 alloc-init 返回的对象，您有责任通过向它发送 release 来放弃它的所有权。或 autorelease消息，你没有这样做。

如您所建议的那样，使用临时变量确实可以解决问题:

CellModel *model = [[CellModel alloc] initialize:@"name" title:@"Name" value: self.currentProfile.name];
[self.naw_rows addObject: model];
[model release];

那么，为什么分析器会报错？因为你的初始值设定项的名称。将其重命名为类似 initWithName:title:value: 的名称并且您会看到“调用者此时不拥有的对象的引用计数的错误减少”消失了。

约定是初始化方法的名称应该以缩写init开头。 .

此外，您的类的实现不会将 self 分配给调用 super 的初始化程序的结果。这:

if (self == [super init])

应该是:

if ((self = [super init]))

或者，如果您愿意:

self = [super init];
if (self)

---

此外，CellModel 的实例变量的内存管理类是错误的。您应该保留或复制作为参数传递给 init 方法的对象，并在 dealloc 中释放它们。

访问器方法也打破了 naming conventions , 它们应该简单地命名为 name , title等。前缀“get”仅用于间接返回对象的方法。