php - Laravel 5.2 理解 "fat model, skinny controller"

Question

我想了解如何在 Laravel 5.2 中使用“胖模型，瘦 Controller ”。基本上，我主要理解为什么，是什么，但不知道怎么做。我在谷歌上搜索了一段时间，发现有几页描述了为什么(有些页面描述了为什么不这样做)和什么，但是没有任何页面可以让您轻松理解如何使用瘦 Controller 创建胖模型。

我创建了一个非常基本的待办事项列表，无需登录或验证，只有最基本的待办事项记录功能。这个应用程序基本上使用“瘦模型，胖 Controller ”，我想重写应用程序，以便它使用“胖模型，瘦 Controller ”。

我在 MySQL 数据库中有三个表:

• 用户
  • id int(10)
  • uname varchar(255)
  • 电子邮件 varchar(255)
  • 密码 varchar(60)
• 项目
  • id int(10)
  • pname varchar(255)
• 笔记
  • id int(10)
  • user_id int(10)
  • project_id int(10)
  • 内容文本
  • time_created 时间戳
  • time_deadline 时间戳
  • 完成 tinyint(1)
  • 删除了 tinyint(1)

当我为表创建迁移时，我使用了 $table->foreign('user_id')->references('id')->on('users'); 和 $table->foreign('project_id')->references('id')->on('projects'); 用于注释表迁移。由于某种原因它没有工作，所以在数据库中 notes.user_id 和 notes.project_id 不是 users.id 和 projects.id，这是一开始的想法。我猜这对我下面的问题并不重要，但如果确实如此，请有人告诉我，这样我就可以尝试解决这个问题。

我有以下模型(已删除文档 block )

应用\用户.php:

<?php

namespace App;

use Illuminate\Foundation\Auth\User as Authenticatable;

class User extends Authenticatable
{
    protected $fillable = [
        'name', 'email', 'password',
    ];

    protected $hidden = [
        'password', 'remember_token',
    ];

    public function notes()
    {
        return $this->hasMany(Note::class);
    }
}

应用\Project.php:

<?php
namespace App;

use Illuminate\Database\Eloquent\Model;

class Project extends Model
{
    public function notes()
    {
        return $this->hasMany(Note::class);
    }
}

应用\Note.php:

<?php
namespace App;

use Illuminate\Database\Eloquent\Model;

class Note extends Model
{
    public function user()
    {
        return $this->belongsTo(User::class);
    }

    public function project()
    {
        return $this->belongsTo(Project::class);
    }
}

我有以下 Controller (已删除文档 block )

应用\Http\Controllers\UserController.php:

<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\User;
use Response;

class UserController extends Controller
{
    public function index()
    {
        try {
            $statusCode = 200;
            $users = User::orderBy('uname', 'asc')->get()->toArray();
            $response = [];

            foreach ($users as $user) {
                $this_row = array(
                    'id' => $user['id'],
                    'name' => $user['uname'],
                );

                $response[] = $this_row;
            }
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return Response::json($response, $statusCode);
        }
    }
}

应用\Http\Controllers\ProjectController.php:

<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\Project;
use Response;

class ProjectController extends Controller
{
    public function index()
    {
        try {
            $statusCode = 200;
            $projects = Project::orderBy('pname', 'asc')->get()->toArray();
            $response = [];

            foreach ($projects as $project) {
                $this_row = array(
                    'id' => $project['id'],
                    'name' => $project['pname'],
                );

                $response[] = $this_row;
            }
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return Response::json($response, $statusCode);
        }
    }
}

应用\Http\Controllers\NoteController.php:

<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\Note;
use App\User;
use App\Project;
use Input;
use Response;
use Redirect;

class NoteController extends Controller
{
    public function index()
    {
        try {
            $statusCode = 200;
            $notes = Note::where('removed', 0)
                ->orderBy('time_created', 'asc')->get()->toArray();
            $response = [];

            foreach ($notes as $note) {
                $user = User::find($note['user_id']); // Username for note
                $project = Project::find($note['project_id']); // Project name

                $this_row = array(
                    'id' => $note['id'],
                    'user' => $user['uname'],
                    'project' => $project['pname'],
                    'content' => $note['content'],
                    'completed' => $note['completed'],
                    'created' => $note['time_created'],
                    'deadline' => $note['time_deadline']
                );

                $response[] = $this_row;
            }
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return Response::json($response, $statusCode);
        }
    }

    public function destroy(Request $request)
    {
        try {
            $statusCode = 200;

            $note = Note::find($request->id);
            $note->removed = 1;
            $note->save();
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return $statusCode;
        }        
    }

    public function edit($request) 
    {
        try {
            $statusCode = 200;

            $note = Note::find($request);

            $response = array(
                'id' => $note['id'],
                'content' => $note['content'],
                'completed' => $note['completed'],
                'deadline' => $note['time_deadline']
            );
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return Response::json($response, $statusCode);
        }
    }

    public function update(Request $request)
    {
        try {
            $statusCode = 200;

            $note = Note::find($request->id);

            $note->content = $request->content;
            $note->time_deadline = $request->deadline;

            if ($request->completed == "true") {
                $note->completed = 1;
            } else {
                $note->completed = 0;
            }

            $note->save();
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return $statusCode;
        }
    }

    public function store(Request $request)
    {
        try {
            $statusCode = 200;

            $note = new Note;

            $note->user_id = $request->user;
            $note->project_id = $request->project;
            $note->content = $request->content;
            $note->time_deadline = $request->deadline;

            $note->save();
        } catch (Exception $e) {
            $statusCode = 400;
        } finally {
            return $statusCode;
        }    
    }
}

最后，这是我的 app/Http/routes.php(已删除注释)

<?php

Route::get('/', function () {
    return view('index');
});

Route::get('/notes', 'NoteController@index');
Route::get('/notes/{id}', 'NoteController@edit');
Route::delete('/notes', 'NoteController@destroy');
Route::put('/notes', 'NoteController@store');
Route::post('/notes', 'NoteController@update');

Route::get('/projects', 'ProjectController@index');
Route::get('/users', 'UserController@index');

Route::group(['middleware' => ['web']], function () {
    //
});

完整代码可以在我的GitHub上找到here .

我正在使用 Angular 接收 Controller 发送的 JSON。这适用于我当前的页面，但如您所见，我的 Controller 有很多逻辑，我想将其移至模型。我不明白我是怎么做到的，所以这是我的问题:

• 我应该创建哪些附加文件？
• 它们应该位于何处？
• 除了当前 Controller 中的逻辑，我还需要这些文件中的什么？
• 我应该如何重写 Controller 来处理来自模型的数据？

Answer 1

您的瘦 Controller 可能如下所示，它将执行与您相同的操作:

<?php
namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Http\Requests;
use App\Http\Controllers\Controller;
use App\Project;

class ProjectController extends Controller
{
    public function index()
    {
        $projects = Project::orderBy('pname', 'asc')->get(['id', 'name']);
        return response()->make($projects);
    }
}

但正如 Fabio 提到的，如果您想更进一步，请查看存储库。这是一篇好文章:https://bosnadev.com/2015/03/07/using-repository-pattern-in-laravel-5/

在大多数情况下，我将存储库包装到服务中以创建业务逻辑。 Controllers 仅处理路由，models 仅包含关系或更改器和访问器。但它可能因开发方法而异。

此外，不要在 foreach 循环中进行数据库查询，利用 Eloquent 的优势，例如:

$notes = Note::where('removed', 0)
            ->with(['user', 'project'])
            ->orderBy('time_created', 'asc')->get();

你可以像这样访问:

foreach($notes as $note)
{
    echo $note->user->uname;
}