java - Spring Boot HTTPServletRequest 无法通过测试正确使用

Question

我试图在这里搜索答案，但找不到。事情就是这样:我正在使用 Spring Boot。我正在使用动态解析查询字符串

@RestController()
@RequestMapping("/processors")
public class ProcessorsController {

    protected static transient Logger log = LoggerFactory.getLogger(ProcessorsController.class);

    private Gson gson = new Gson();

    @Autowired
    HttpServletRequest request;

    private Options options = new Options();

    @Autowired
    ProcessorRepository processorRepository;

    //Inside a method, I am populating the Options<String, String> map using
    //request.getParameterMap() 

    @CrossOrigin
    @RequestMapping(value = "/{name}/run", method = RequestMethod.POST, produces = MediaType.APPLICATION_JSON_VALUE)
    String run(@RequestBody String input, @PathVariable("name") String name) {
        Validate.notEmpty(input, "The request body must contain an not empty text");
        return runProcessor(input, name);
    }

    private String runProcessor(String input, String name) {
        Validate.notEmpty(name, "The processor name cannot be empty");
        Processor processor = processorRepository.getProcessorCalled(name);
        addOptions();
        return processor.run(input, options);
    }

    private void addOptions() {
        request.getParameterMap().forEach((k, v) -> {
            if (!k.equals("text")) {
                if (v[0] != null && !v[0].isEmpty()) {
                    options.put(k, v[0]);
                }
            }
        });
    }
}

这在手动测试中运行良好，但我正在尝试编写单元测试。以下是示例:

@ActiveProfiles("test")
@RunWith(SpringJUnit4ClassRunner.class)
@SpringApplicationConfiguration(classes = {HAL.class, ProcessorsController.class})
@WebAppConfiguration
public abstract class ProcessorsControllerAbstractTest {

    MockMvc mvc;

    @Autowired
    ProcessorRepository processorRepository;

    @Autowired
    HttpServletRequest request;

    @Autowired
    ProcessorsController processorsController;


    @Before
    public void setUp() throws Exception {
        processorsController.processorRepository = processorRepository;
        processorsController.request = request;
        mvc = MockMvcBuilders.standaloneSetup(processorsController).build();
    }
}

和在实际测试类中

public class ProcessorsControllerTest extends ProcessorsControllerAbstractTest {
    //other test cases
    @Test
    public void testAddOptions() throws Exception {
        mvc.perform(MockMvcRequestBuilders.post("/processors/default/run").param("size", "500").content(input).contentType(MediaType.APPLICATION_JSON)).andExpect(status().isOk());
        Assert.assertEquals("500", options.get("size"));
    }
}

我无法在 request.getParameterMap() 获取请求对象值(例如 size 之类的参数)。有什么办法可以访问它吗？如果不是，那么测试它的另一种方法是什么？提前致谢!

Answer 1

你不应该自动连接 HttpServletRequest这是一个非常糟糕的主意。

而是添加一个 @RequestParam Map<String,String> params到您的方法签名，这将自动包含所有参数。正如解释的那样 here在引用指南中。

@CrossOrigin
@RequestMapping(value = "/{name}/run", method = RequestMethod.POST, produces = MediaType.APPLICATION_JSON_VALUE)
String run(@RequestBody String input, @PathVariable("name") String name, @RequestParam Map<String, String> params) {
    Validate.notEmpty(input, "The request body must contain an not empty text");
    return runProcessor(input, name, params);
}

现在您的 Controller 也存在缺陷，因为它存储了 Options作为实例变量。 Controller 是一个单例现在想象一下当 10 个请求同时开始修改这个实例时会发生什么。更改您的 runProcessor和 addOptions为此的方法。

private String runProcessor(String input, String name, Map<String, String> params) {
    Validate.notEmpty(name, "The processor name cannot be empty");
    Processor processor = processorRepository.getProcessorCalled(name);
    Options options = new Options();
    addOptions(options, params);
    return processor.run(input, options);
}

private void addOptions(Options options, Map<String, String> params) {
    params.forEach((k, v) -> {
        if (!k.equals("text")) {
            if (v != null && !v.isEmpty()) {
                options.put(k, v);
            }
        }
    });
}

您可能想要添加 addOptions到 Options class 而不是(或者将其添加到构造函数中，以便您可以构造一个 Options 带有 Map<String, String> 的实例。