Java if 语句

Question

public void searchKlijenta(KlijentiFormEvent klijentiFormEvent) throws SQLException {

    String nazivK = klijentiFormEvent.getNaziv();
    String adresaK = klijentiFormEvent.getAdresa();
    String gradK = klijentiFormEvent.getGrad();
    String drzavaK = klijentiFormEvent.getDrzava();
    String telefonK = klijentiFormEvent.getTelefon();
    String faxK = klijentiFormEvent.getFax();
    String mailK = klijentiFormEvent.getMail();
    String mobitelK = klijentiFormEvent.getMobitel();
    String oibK = klijentiFormEvent.getOib();
    String ugovorK = klijentiFormEvent.getUgovor();
    String osobaK = klijentiFormEvent.getOsoba();

    if (nazivK.length() == 0) 
        nazivK = null;
    if (adresaK.length() == 0) 
        adresaK = null;
    if (gradK.length() == 0) 
        gradK = null;
    if (drzavaK.length() == 0) 
        drzavaK = null;
    if (telefonK.length() == 0) 
        telefonK = null;
    if (faxK.length() == 0) 
        faxK = null;
    if (mailK.length() == 0) 
        mailK = null;
    if (mobitelK.length() == 0) 
        mobitelK = null;
    if (oibK.length() == 0) 
        oibK = null;
    if (ugovorK.length() == 0) 
        ugovorK = null;
    if (osobaK.length() == 0) 
        osobaK = null;


    klijentiSearchModel.clear();

    String sql = "select * from zavrsni.klijenti where naziv like '"+nazivK+"' or adresa like '"+adresaK+"' or grad like '"+gradK+"' or drzava like '"+drzavaK+"' or telefon like '"+telefonK+"' or fax like '"+faxK+"' or mail like '"+mailK+"' or mobitel like '"+mobitelK+"' or oib like '"+oibK+"' or ugovor like '"+ugovorK+"' or osoba like '"+osobaK+"' ";
    Statement selectStmt = con.createStatement();
    ResultSet result = selectStmt.executeQuery(sql);

    while(result.next()) {
        int id = result.getInt("id");
        String naziv = result.getString("naziv");
        String adresa = result.getString("adresa");
        String grad = result.getString("grad");
        int posBr = result.getInt("posBr");
        String drzava = result.getString("drzava");
        String telefon = result.getString("telefon");
        String fax = result.getString("fax");
        String mail = result.getString("mail");
        String mobitel = result.getString("mobitel");
        String oib = result.getString("oib");
        String ugovor = result.getString("ugovor");
        String osoba = result.getString("osoba");

        KlijentiModelSearch klijentSearch = new KlijentiModelSearch(id, naziv, adresa, grad, posBr, drzava, telefon, fax, mail, mobitel, oib, ugovor, osoba);
        klijentiSearchModel.add(klijentSearch);
    }

    result.close();
    selectStmt.close();

}

我可以把这段代码写得更短吗？我想到了“if”语句？

也许通过一个 while 循环？

用于在数据库中搜索某些客户端的方法。这种方法很有效，但我想把这个 if 语句写得更短。

谢谢

编辑已解决:

public void traziKlijenta(KlijentiFormEvent klijentiFormEvent) throws SQLException {

    String nazivK = returnNullIfEmptys(klijentiFormEvent.getNaziv());
    String adresaK = returnNullIfEmptys(klijentiFormEvent.getAdresa());
    String gradK = returnNullIfEmptys(klijentiFormEvent.getGrad());
    String drzavaK = returnNullIfEmptys(klijentiFormEvent.getDrzava());
    String telefonK = returnNullIfEmptys(klijentiFormEvent.getTelefon());
    String faxK = returnNullIfEmptys(klijentiFormEvent.getFax());
    String mailK = returnNullIfEmptys(klijentiFormEvent.getMail());
    String mobitelK = returnNullIfEmptys(klijentiFormEvent.getMobitel());
    String oibK = returnNullIfEmptys(klijentiFormEvent.getOib());
    String ugovorK = returnNullIfEmptys(klijentiFormEvent.getUgovor());
    String osobaK = returnNullIfEmptys(klijentiFormEvent.getOsoba());

    klijentiSearchModel.clear();

    String sql = "select * from zavrsni.klijenti where naziv like '%"+nazivK+"%' or adresa like '%"+adresaK+"%' or grad like '%"+gradK+"%' or drzava like '%"+drzavaK+"%' or telefon like '%"+telefonK+"%' or fax like '%"+faxK+"%' or mail like '%"+mailK+"%' or mobitel like '%"+mobitelK+"%' or oib like '%"+oibK+"%' or ugovor like '%"+ugovorK+"%' or osoba like '%"+osobaK+"%' ";
    Statement selectStmt = con.createStatement();
    ResultSet result = selectStmt.executeQuery(sql);

    while(result.next()) {
        int id = result.getInt("id");
        String naziv = result.getString("naziv");
        String adresa = result.getString("adresa");
        String grad = result.getString("grad");
        int posBr = result.getInt("posBr");
        String drzava = result.getString("drzava");
        String telefon = result.getString("telefon");       
        String fax = result.getString("fax");
        String mail = result.getString("mail");
        String mobitel = result.getString("mobitel");
        String oib = result.getString("oib");
        String ugovor = result.getString("ugovor");
        String osoba = result.getString("osoba");

        KlijentiModelSearch klijentSearch = new KlijentiModelSearch(id, naziv, adresa, grad, posBr, drzava, telefon, fax, mail, mobitel, oib, ugovor, osoba);
        klijentiSearchModel.add(klijentSearch);
    }

    result.close();
    selectStmt.close();

}
private String returnNullIfEmptys(String value) {
    if (value == null || value.length() == 0) {
        return null;
    }
    return value;
}

Answer 1

对于您的实际代码，@khelwood 在您的评论问题中提出的建议是最好的方法。
其他解决方案会产生开销并更改您的设计而不会带来附加值。

public static String returnNullIfEmpty(String value){
   if (value == null || value.length() == 0){
      return null;
   }
     return value;
}

然后你可以这样调用它:

nazivK = returnNullIfEmpty(nazivK);
adresaK= returnNullIfEmpty(adresaK);

编辑

通过编辑您的问题，您可以将处理作为从 klijentiFormEvent 对象检索值的时间包括在内:

String nazivK =  returnNullIfEmpty(klijentiFormEvent.getNaziv());
String adresaK = returnNullIfEmpty(klijentiFormEvent.getAdresa());
...