gpt4 book ai didi

php - 这种 PHP 对象设计方法是好是坏? - 寻求批评

转载 作者:搜寻专家 更新时间:2023-10-31 20:46:26 26 4
gpt4 key购买 nike

<分区>

我对以 OOP 方式使用 PHP 还比较陌生。在我最新的项目中,我将创建一个站点,该站点将从 SQL 数据库加载大量条目,然后将这些条目发送到 View 以进行输出。

在摆弄如何以最佳方式做到这一点的同时,我创建了如下所列的代码:

class entryHandler {

//Store database connection
protected $database;

//List of all entries as multidimensional array fetched from SQL.
private $entriesSQL = array();

//List of all entries (as objects) will be stored in our $entries array
private $entriesObjects = array();


/*
*
* Upon construct
*
*/
public function __construct($database) {

//Check if database class has been passed correctly.
//Else we exit, since we can not function without it!
if (isset($database)) {

$this -> database = $database;

//Get events
if ($entriesSQL = $this -> getEventsFromSQL()) {
// Set SQL entries
$this -> setEntriesSQL($entriesSQL);

//And turn them into an array of objects
$this -> setEntryObjects();
}
else {

}
}
else {
echo 'No database connection has been established. Exiting execution.';
exit();
}
}


/*
* Setter for entriesSQL
*/
private function setEntriesSQL($entriesSQL) {
$this -> entriesSQL = $entriesSQL;
}


/*
* Getter for entriesSQL
*/
public function getEntriesSQL() {
return $this -> entriesSQL;
}


/*
* Setter for entry objects
*
*/
private function setEntryObjects() {
foreach ($this -> getEntriesSQL() as $key => $val) {
//entryID, entryUserID, entryTitle, entryTimeStart, entryTimeEnd
array_push($this -> entriesObjects, new entry($val['entryID'], $val['entryUserID'], $val['entryTitle'], $val['entryTimeStart'], $val['entryTimeEnd']));
}
}


/*
*
* Getter for entry objects
*
*/
public function getEntryObjects() {
return $this -> entriesObjects;
}

/*
*
* This function grabs events from SQL and return multidimensional-array of content.
*
*/
private function getEventsFromSQL() {
//Define the SQL query
$SQL = '...snippet...';

if ($entriesSQL = $this -> database -> read($SQL)) {
//Entries collected, return them.
return $entriesSQL;
}
else {
//Error occured. Log it and return false.
return false;
}
}

}


class entry {

var $entryID;
var $entryUserID;
var $entryTitle;
var $entryTimeStart;
var $entryTimeEnd;

public function __construct($entryID, $entryUserID, $entryTitle, $entryTimeStart, $entryTimeEnd) {
$this -> setEntryID($entryID);
$this -> setEntryUserID($entryUserID);
$this -> setEntryTitle($entryTitle);
$this -> setEntryTimeStart($entryTimeStart);
$this -> setEntryTimeEnd($entryTimeEnd);
}

/*
* Setter for entryID
*/
private function setEntryID($entryID) {
$this -> entryID = $entryID;
}

/*
* Getter for entryID
*/
public function getEntryID() {
return $this -> entryID;
}



/*
* Setter for entryUserID
*/
private function setEntryUserID($entryUserID) {
$this -> entryUserID = $entryUserID;
}

/*
* Getter for entryUserID
*/
public function getEntryUserID() {
return $this -> entryUserID;
}



/*
* Setter for entryTitle
*/
private function setEntryTitle($entryTitle) {
$this -> entryTitle = $entryTitle;
}

/*
* Getter for entryTitle
*/
public function getEntryTitle() {
return $this -> entryTitle;
}



/*
* Setter for entryTimeStart
*/
private function setEntryTimeStart($entryTimeStart) {
$this -> entryTimeStart = $entryTimeStart;
}

/*
* Getter for entryTimeStart
*/
public function getEntryTimeStart() {
return $this -> entryTimeStart;
}


/*
* Setter for entryTimeEnd
*/
private function setEntryTimeEnd($entryTimeEnd) {
$this -> entryTimeEnd = $entryTimeEnd;
}

/*
* Getter for entryTimeEnd
*/
public function getEntryTimeEnd() {
return $this -> entryTimeEnd;
}
}

现在,“entryHandler”类从我的 Controller (在另一个 PHP 文件中)加载,如下所示:

    //Instantiate calenderHandler and pass our database handler to it.
$entryHandler = new entryHandler($database);

//Load template
$template -> calendarEntries = $this -> renderEntries($entryHandler -> getEntryObjects());



/*
*
* This functions renders entries content for view.
* Returns string with content.
*
*/
private function renderEntries($entries) {

$entriesContent = '';

foreach ($entries as $entry) {

$entriesContent .= '{
title: "' . $entry -> getEntryTitle() . '",
start: "' . $entry -> getEntryTimeStart() . '",
end: "' . $entry -> getEntryTimeEnd() . '"
}, ';
}

//Right trim entries string, so that we do not add trailing comma to last entry in list.
$entriesContent = rtrim($entriesContent, ', ');

//And return content to parse it to view.
return $entriesContent;
}
}

这是一个糟糕的设计模式吗?有什么我应该以另一种方式做的吗?这段代码中有某种冗余吗? - 我应该注意什么?

感谢大家的宝贵时间。

您好,菲舍尔

26 4 0
Copyright 2021 - 2024 cfsdn All Rights Reserved 蜀ICP备2022000587号
广告合作:1813099741@qq.com 6ren.com