c++ - vector 迭代器不兼容 : DEBUG

Question

为什么这段代码给我错误:Vector iterators incompatible

这段代码追溯到Rogue Wave文件tpordvec.h

    std::vector<T*> v;
    const T* a  // Where T is a template Class 
    for (std::vector<T*>::iterator p = v.begin(); p != v.end(); p++)
    {
        if (**p == *a)
        {
            T* temp = *p;
            if ( v.erase(p) == v.end()) //ASSERTION ERROR HERE
               return NULL;

            return temp;
        }
    }

Answer 1

http://en.cppreference.com/w/cpp/container/vector/erase

Iterators and references to the erased elements and to the elements between them and the end of the container are invalidated. The past-the-end iterator is also invalidated.

因此，如果 vector.end() 在 vector.erase() 和 vector.erase() 真正删除和这样做会使迭代器在 end() 之前无效，对 operator==() 的调用将在两个不兼容的迭代器之间进行。

像这样会更好:

auto it = v.erase(p); 
if ( it == v.end())
{ 
       return NULL;
}