python - 尽管传递了参数列表，为什么将变量传递给 subprocess.Popen 不起作用？

Question

我有一个脚本，它通过 subprocess.Popen 调用另一个 Python 脚本。但是因为我有参数存储在变量中

servers[server]['address']
servers[server]['port']
servers[server]['pass']

我无法执行命令

p = subprocess.Popen(
    ["python mytool.py -a ", servers[server]['address'], "-x", servers[server]['port'], "-p", servers[server]['pass'], "some additional command"],
    shell=True,
    stdout=subprocess.PIPE
)

Answer 1

删除 shell=True。 The arguments to Popen() are treated differently on Unix if shell=True :

import sys
from subprocess import Popen, PIPE

# populate list of arguments
args = ["mytool.py"]
for opt, optname in zip("-a -x -p".split(), "address port pass".split()):
    args.extend([opt, str(servers[server][optname])])
args.extend("some additional command".split())

# run script
p = Popen([sys.executable or 'python'] + args, stdout=PIPE)
# use p.stdout here...
p.stdout.close()
p.wait()

请注意，为具有外部输入的命令传递 shell=True 是一种安全隐患，如警告 in the docs 所述.