ruby-on-rails - Rspec Controller 测试通常是否太长？

Question

我的 spec/controllers/decidings_controller_spec.rb 在下面。

RSpec.describe DecidingsController, type: :controller do
 describe '#create' do
     before do
       @deciding=build(:deciding_consenting_false)
     end
     context 'correct_user login' do
         before do 
             login_user(@deciding.asking.user)
         end
         it 'creates with deciding +1' do
           expect{post :create , undertaking_id: @deciding.undertaking_id , asking_id: @deciding.asking_id}.to change(Deciding , :count).by(1)
         end
         it 'redirects to undertking' do
             post :create , undertaking_id: @deciding.undertaking_id , asking_id: @deciding.asking_id
             expect(response).to redirect_to @deciding.undertaking
         end
     end
     context 'incorrect_user login' do
         before do 
             @user=create(:user)
             login_user(@user)
         end
         it 'creates with deciding 0' do
           expect{post :create , undertaking_id: @deciding.undertaking_id , asking_id: @deciding.asking_id}.to change(Deciding , :count).by(0)
         end
         it 'redirects to undertking' do
             post :create , undertaking_id: @deciding.undertaking_id , asking_id: @deciding.asking_id
             expect(response).to redirect_to root_path
         end
     end
end
describe '#destroy' do
    context 'before deciding consent' do
        before do
            @deciding=create(:deciding_consenting_false)
        end
        context 'correct_user login' do
            before do
               login_user(@deciding.asking.user)
            end
            it 'destroy with deciding -1' do
                expect{delete :destroy , undertaking_id: @deciding , asking_id: @deciding}.to change(Deciding , :count).by(-1)
            end
            it 'redirects undertaking show' do
                delete :destroy , undertaking_id: @deciding.undertaking_id , asking_id: @deciding.asking_id
                expect(response).to redirect_to @deciding.undertaking
            end
        end
        context 'incorrect_user login' do
            before do
                user=create(:user)
                login_user(user)
            end
            it 'destroy with deciding -1' do
                expect{delete :destroy , undertaking_id: @deciding , asking_id: @deciding}.to change(Deciding , :count).by(0)
            end
            it 'redirects undertaking show' do
                delete :destroy , undertaking_id: @deciding.undertaking_id , asking_id: @deciding.asking_id
                expect(response).to redirect_to root_path
            end
        end
    end
    context ' if after deciding consent( should #before_consent)' do
        before do
            @deciding=create(:deciding_consenting_true)
        end
        context 'correct_user login' do
            before do
               login_user(@deciding.asking.user)
            end
            it 'destroy with deciding 0' do
                expect{delete :destroy , undertaking_id: @deciding , asking_id: @deciding}.to change(Deciding , :count).by(0)
            end
            it 'redirects undertaking show' do
                delete :destroy , undertaking_id: @deciding.undertaking_id , asking_id: @deciding.asking_id
                expect(response).to redirect_to root_path
            end
        end
    end
 end
 describe '#consent' do
    context 'correct_user login' do
        before do
            @deciding=create(:deciding_consenting_false)
            login_user(@deciding.undertaking.user)
        end
        it 'consenting changes true' do
            patch :consent , undertaking_id: @deciding.undertaking_id
            @deciding.reload
            expect(@deciding.consenting).to eq true
        end
        it 'redirect_to undertaking' do
            patch :consent , undertaking_id: @deciding.undertaking_id
            expect(response).to redirect_to @deciding.undertaking
        end  
    end
    context 'asking user login' do
        before do
            @deciding=create(:deciding_consenting_false)
            login_user(@deciding.asking.user)
        end
        it 'consenting not changes true' do
            patch :consent , undertaking_id: @deciding.undertaking_id
            @deciding.reload
            expect(@deciding.consenting).to eq false               
        end
        it 'redirect_to root' do
            patch :consent , undertaking_id: @deciding.undertaking_id
            expect(response).to redirect_to root_path
        end
    end
    context 'incorrect_user login' do
        before do
            @deciding=create(:deciding_consenting_false)
            @user=create(:user)
            login_user(@user)
        end
        it 'consenting not changes true' do
            patch :consent , undertaking_id: @deciding.undertaking_id
            @deciding.reload
            expect(@deciding.consenting).to eq false           
        end
        it 'redirect_to root' do
            patch :consent , undertaking_id: @deciding.undertaking_id
            expect(response).to redirect_to root_path
        end
    end
end
describe '#deciding_cancel' do
    context 'correct_user login' do
        context 'asking user login' do
            context 'should #after_consent' do
                before do
                    @deciding=create(:deciding_consenting_true)
                    login_user(@deciding.asking.user)
                end

            end
            context 'should not before consent' do
                before do
                    @deciding=create(:deciding_consenting_false)
                    login_user(@deciding.asking.user)
                end                   
            end
            context 'should #before_finish' do
                before do
                    @deciding=create(:deciding_consenting_true)
                    login_user(@deciding.asking.user)
                end

            end
            context 'should not before finish' do
                before do
                    @deciding=create(:deciding_after_finish)
                    login_user(@deciding.asking.user)
                end                   
            end
        end
        context 'undertaking user login' do
        end
    end
    context 'incorrect_user login' do
        before do
            @user=create(:user)
        end
    end
end


describe '#deciding_cancel' do
    context 'correct_user login' do
    end
    context 'incorrect_user login' do
    end
end
describe '#deciding_cancel' do
    context 'correct_user login' do
    end
    context 'incorrect_user login' do
    end
end

结束

我的 Decidingscontroller 有很多用于条件分支的 before_action。所以我的规范文件变得太长了。在这种情况下还有其他方法吗？如果还有其他方法可以缩短程序，请告诉我。

无论如何，我的 controllers/decidings_controller.rb 在下面。

   class DecidingsController < ApplicationController

#correct_user?
before_action :authenticate_user! 
before_action :asking_user!, only: [:create , :destroy , :asking_finish , :finish_cancel ]
before_action :undertaking_user!, only: [:consent , :undertaking_finish]
before_action :asking_or_undertaking_user! , only: [:deciding_cancel,:deciding_cancel_consent , :deciding_cancel_refuse]
before_action :reverse_user! ,only: [:deciding_cancel_consent , :deciding_cancel_refuse]

#流れ
before_action :before_consent , only: [:destroy]
before_action :after_consent , only: [:deciding_cancel ,:deciding_cancel_consent , :deciding_cancel_refuse, :undertaking_finish , :asking_finish , :finish_cancel ]
before_action :before_finish , only: [:deciding_cancel ,:deciding_cancel_consent , :deciding_cancel_refuse]
before_action :after_deciding_cancel , only: [:deciding_cancel_consent , :deciding_cancel_refuse]
before_action :after_undertaking_finish , only: [:asking_finish , :finish_cancel]


def create
    asking=Asking.find(params[:asking_id])
    undertaking=Undertaking.find(params[:undertaking_id])
    deciding=Deciding.new(asking_id: asking.id , undertaking_id: undertaking.id)
    if deciding.save
        flash[:success] = "契約作成に成功しました。"
        redirect_to undertaking
    else
        flash[:alert] = "契約作成に失敗しました。"
        redirect_to undertaking
    end
end
def destroy
  asking=Asking.find(params[:asking_id])
  undertaking=Undertaking.find(params[:undertaking_id])
  asking.deciding.destroy
  flash[:info]='契約申し込みをキャンセルしました。'
  redirect_to undertaking
end
def consent
    undertaking=Undertaking.find(params[:undertaking_id])
    if undertaking.deciding
        undertaking.deciding.update(consenting: true)
        flash[:success] = "契約が成立しました。"
        redirect_to undertaking
    else
        redirect_to root_path
    end
end
def deciding_cancel
    undertaking=Undertaking.find(params[:undertaking_id])
    undertaking.deciding.update(cancel: true , cancel_userid: current_user.id)
    flash[:success] = "途中終了リクエストを送信しました。"
    redirect_to undertaking
end
def deciding_cancel_consent
    undertaking=Undertaking.find(params[:undertaking_id])
    undertaking.deciding.destroy        
    flash[:success] = "契約が途中終了されました。"
    redirect_to undertaking
end
def deciding_cancel_refuse
    undertaking=Undertaking.find(params[:undertaking_id])
    undertaking.deciding.update(cansel: false , cansel_userid: nil)       
    flash[:success] = "契約の途中終了を却下しました。"
    redirect_to undertaking
end
def undertaking_finish
    undertaking=Undertaking.find(params[:undertaking_id])
    undertaking.deciding.update(finish_undertaking: true)
    flash[:success] = "納品が完了しました。"
    redirect_to undertaking
end
def finish_cancel
    undertaking=Undertaking.find(params[:undertaking_id])
    undertaking.deciding.update(finish_undertaking: false)
    flash[:success] = "再納品リクエストを送信しました。"
    redirect_to undertaking
end
def asking_finish
    undertaking=Undertaking.find(params[:undertaking_id])
    undertaking.deciding.update(finish_asking: true)
    flash[:success] = "納品が成立しました。"
    redirect_to asking
end


private

def asking_user!
    asking=Asking.find(params[:asking_id])
    unless asking.user==current_user
        redirect_to root_path
    end
end
def undertaking_user!
    undertaking=Undertaking.find(params[:undertaking_id])
    unless undertaking.user==current_user
        redirect_to root_path
    end
end     
def asking_or_undertaking_user!
    undertaking=Undertaking.find(params[:undertaking_id])
    unless current_user==undertaking.user || current_user==undertaking.asking.user
      refirect_to root_path
    end
end
def reverse_user!
     undertaking=Undertaking.find(params[:undertaking_id])
     if current_user.id == undertaking.deciding.cansel_userid
         refirect_to root_path
     end
end

def before_consent
    undertaking=Undertaking.find(params[:undertaking_id])
    if undertaking.deciding.consenting
        redirect_to root_path
    end
end


def after_consent
    asking=Asking.find(params[:asking_id])
    unless asking.deciding.consenting
        redirect_to root_path
    end
end

def before_finish
    undertaking=Undertaking.find(params[:undertaking_id])
    if undertaking.deciding.finish_undertaking
        redirect_to root_path
    end
end

def after_deciding_cancel
    undertaking=Undertaking.find(params[:undertaking_id])
    unless undertaking.deciding.cancel
        redirect_to root_path
    end
end

def after_undertaking_finish
    undertaking=Undertaking.find(params[:undertaking_id])
    unless undertaking.deciding.finish_undertaking
        redirect_to root_path
    end
end    

结束

请帮帮我...

Answer 1

我不会担心 Rails 中的长 Controller 和规范文件。

这些文件往往会变得很长，保持类和方法简短的通常建议不一定适用于 Controller 及其规范。

比如我们生产系统中的user_controller.rb是8500行，对应的user_controller_spec.rb是7000行。

这是我们排名前 10 的 Controller 的长度

1285 app/controllers/*********_controller.rb
1430 app/controllers/***********_controller.rb
1444 app/controllers/****_controller.rb
1950 app/controllers/****_controller.rb
1994 app/controllers/********_controller.rb
2530 app/controllers/***********_controller.rb
2697 app/controllers/*********_controller.rb
2998 app/controllers/*****_controller.rb
3134 app/controllers/application_controller.rb
8737 app/controllers/users_controller.rb