ruby-on-rails - 如何进一步重构 ruby 哈希

Question

我正在编写一个接受字符串并返回相应模型类的函数。旧版本由难看的 case 语句组成，重构后的版本有一个不那么难看的散列。然而，哈希对我来说仍然是重复的。你能给我一些建议吗？

# original function

def determine_node_label(category)
  label = 
    case category 
    when 'boundary box'
      Slide
    when 'circle', 'rectangle'
      GroupBox
    when 'text'
      Text
    when 'picture', 'pie', 'bar' , 'trend', 'star'
      Content
    else
      Content
    end
  return label 
end

# refactored function

def determine_node_label(category)
  label = {
    "boundary box" => Slide,
    "circle" => GroupBox,
    "rectangle" => GroupBox,
    "text" => Text,
    "picture" => Content,
    "pie" => Content,
    "bar" => Content,
    "trend" => Content,
    "star" => Content
  }
  label.default = Content
  return label["category"]
end

更新:

我对假设 label.default 会发生变化的解决方案更感兴趣。我很抱歉没有在代码中明确这一点。

Answer 1

这个呢？

LABELS = {
  "boundary box" => Slide,
  "circle"       => GroupBox,
  "rectangle"    => GroupBox,
  "text"         => Text
} 

def determine_node_label(category)
  LABELS[category] || Content
end